[opt](nereids) add project under aggregate to enable extract common sub expression #40473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40696 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40961 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40508 ms |
TPC-DS: Total hot run time: 188016 ms |
Contributor
Author
|
run buildall |
2 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42459 ms |
TPC-DS: Total hot run time: 193345 ms |
ClickBench: Total hot run time: 31.23 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41630 ms |
TPC-DS: Total hot run time: 198226 ms |
ClickBench: Total hot run time: 31.71 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41866 ms |
TPC-DS: Total hot run time: 193735 ms |
ClickBench: Total hot run time: 31.89 s |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
1 similar comment
Contributor
Author
|
run cloud_p0 |
starocean999
approved these changes
Sep 12, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
approved these changes
Sep 12, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ub expression (#40473) ## Proposed changes project aggregate function parameters, and then apply common_sub_expression opt by CommonSubExpressionOpt post processor. example: agg( sum(A+B), avg(A+B)) +--->Scan(T) => agg(sum(x) , avg(x)) +---> project (A+B as x) +--->Scan(T) tpcds 64 changed TPCDS 1T， 3BE before： 6050 ms after： 6075 ms Issue Number: close #xxx <!--Describe your changes.-->
16 tasks
englefly
added a commit
that referenced
this pull request
Jan 15, 2025
…agg (#46627) ### What problem does this PR solve? after extracting common expressions for agg, the underlying projection may project redundant columns. for example: original plan Agg(groupkey=[A+B, A+B+1]) --> project(A, B) after extracting, "A+B as C" is detected as a common expression, and the plan becomes Agg(groupKey=[C, C+1]) -->project(A, B, A+B as C) here A, B should not be projected, since they are not used any more. so the optimal plan is Agg(groupKey=[C, C+1]) -->project(A+B as C) Related PR: #40473
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…agg (#46627) ### What problem does this PR solve? after extracting common expressions for agg, the underlying projection may project redundant columns. for example: original plan Agg(groupkey=[A+B, A+B+1]) --> project(A, B) after extracting, "A+B as C" is detected as a common expression, and the plan becomes Agg(groupKey=[C, C+1]) -->project(A, B, A+B as C) here A, B should not be projected, since they are not used any more. so the optimal plan is Agg(groupKey=[C, C+1]) -->project(A+B as C) Related PR: #40473
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…agg (apache#46627) ### What problem does this PR solve? after extracting common expressions for agg, the underlying projection may project redundant columns. for example: original plan Agg(groupkey=[A+B, A+B+1]) --> project(A, B) after extracting, "A+B as C" is detected as a common expression, and the plan becomes Agg(groupKey=[C, C+1]) -->project(A, B, A+B as C) here A, B should not be projected, since they are not used any more. so the optimal plan is Agg(groupKey=[C, C+1]) -->project(A+B as C) Related PR: apache#40473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
project aggregate function parameters, and then apply common_sub_expression opt by CommonSubExpressionOpt post processor.
example:
agg( sum(A+B), avg(A+B))
+--->Scan(T)
=>
agg(sum(x) , avg(x))
+---> project (A+B as x)
+--->Scan(T)
tpcds 64 changed
TPCDS 1T， 3BE
before： 6050 ms
after： 6075 ms
Issue Number: close #xxx