Skip to content

Conversation

@caiconghui
Copy link
Contributor

This PR is mainly to fix thread resource leak, and then add some notice to use newDaemonScheduledThreadPool api in ThreadPoolManager .

@caiconghui
Copy link
Contributor Author

for #4046

@morningman morningman added area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug. labels Jul 8, 2020
@morningman
Copy link
Contributor

Most of UT are failed. I do not know why... Have you run it in your local env?

@morningman morningman self-assigned this Jul 15, 2020
@caiconghui
Copy link
Contributor Author

Most of UT are failed. I do not know why... Have you run it in your local env?

my bad, I will fix it.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 16, 2020
@morningman morningman merged commit db50c19 into apache:master Jul 16, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jul 16, 2020
…log destroyed (apache#4049)

This PR is mainly to fix thread resource leak, and then add some notice
to use newDaemonScheduledThreadPool api in ThreadPoolManager.
@caiconghui caiconghui deleted the threadpool_leak branch July 30, 2020 02:21
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants