[Branch 2.1] backport systable PRs. #40642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Vallishp
requested review from
CalvinKirs,
dataroaring,
gavinchou,
morningman and
platoneko
as code owners
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #ifndef _SCHEMA_SCANNER_HELPER_H_ | ||
|
|
||
| #include <stdint.h> |
Contributor
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]
Suggested change
| #include <stdint.h> | |
| #include <cstdint> |
| {"PROPERTIES", TYPE_STRING, sizeof(StringRef), true}, | ||
| }; | ||
|
|
||
| SchemaTableOptionsScanner::SchemaTableOptionsScanner() |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/exec/schema_scanner/schema_table_options_scanner.cpp:40:
- : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_TABLE_OPTIONS) {}
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_TABLE_OPTIONS) = default;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
backport
#40568
#40455
#40456
#40153
#34384