Skip to content

[Fix](parquet-reader) Fix parquet reader crash in set_dict(). #40643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Sep 13, 2024
Merged

[Fix](parquet-reader) Fix parquet reader crash in set_dict(). #40643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions be/src/vec/exec/format/parquet/byte_array_dict_decoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ namespace doris::vectorized {
Status ByteArrayDictDecoder::set_dict(std::unique_ptr<uint8_t[]>& dict, int32_t length,
size_t num_values) {
_dict = std::move(dict);
if (_dict == nullptr) {
return Status::Corruption("Wrong dictionary data for byte array type, dict is null.");
}
_dict_items.reserve(num_values);
uint32_t offset_cursor = 0;
char* dict_item_address = reinterpret_cast<char*>(_dict.get());
Expand Down
3 changes: 3 additions & 0 deletions be/src/vec/exec/format/parquet/fix_length_dict_decoder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ class FixLengthDictDecoder final : public BaseDictDecoder {
return Status::Corruption("Wrong dictionary data for fixed length type");
}
_dict = std::move(dict);
if (_dict == nullptr) {
return Status::Corruption("Wrong dictionary data for byte array type, dict is null.");
}
char* dict_item_address = reinterpret_cast<char*>(_dict.get());
_dict_items.resize(num_values);
for (size_t i = 0; i < num_values; ++i) {
Expand Down