Skip to content

[branch-2.1](nereids) remove interface Nondeterministic and fix random/random_bytes foldable properties (#39944) #40650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Sep 11, 2024
Merged

[branch-2.1](nereids) remove interface Nondeterministic and fix random/random_bytes foldable properties (#39944) #40650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions .../src/main/java/org/apache/doris/nereids/trees/expressions/functions/Nondeterministic.java
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions ...ore/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Random.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,9 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) {
public boolean isDeterministic() {
return false;
}

@Override
public boolean foldable() {
return false;
}
}
13 changes: 11 additions & 2 deletions ...rc/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/RandomBytes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import org.apache.doris.catalog.FunctionSignature;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.functions.Nondeterministic;
import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
import org.apache.doris.nereids.types.IntegerType;
Expand All @@ -36,7 +35,7 @@
* ScalarFunction 'random_bytes'. This class is generated by GenerateFunction.
*/
public class RandomBytes extends ScalarFunction
implements ExplicitlyCastableSignature, PropagateNullable, Nondeterministic {
implements ExplicitlyCastableSignature, PropagateNullable {

public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
FunctionSignature.ret(StringType.INSTANCE).args(IntegerType.INSTANCE),
Expand All @@ -60,6 +59,16 @@ public RandomBytes withChildren(List<Expression> children) {
return new RandomBytes(children.get(0));
}

@Override
public boolean isDeterministic() {
return false;
}

@Override
public boolean foldable() {
return false;
}

@Override
public List<FunctionSignature> getSignatures() {
return SIGNATURES;
Expand Down