Skip to content

[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE crash #40726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lide-reed merged 1 commit into from
Sep 14, 2024
Merged

[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE crash #40726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions be/src/vec/functions/function_encryption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,9 @@ struct EncryptionAndDecryptTwoImpl {
if (mode_arg.size != 0) {
if (!aes_mode_map.contains(mode_str)) {
all_insert_null = true;
} else {
encryption_mode = aes_mode_map.at(mode_str);
}
encryption_mode = aes_mode_map.at(mode_str);
}
const ColumnString::Offsets* offsets_column = &column->get_offsets();
const ColumnString::Chars* chars_column = &column->get_chars();
Expand Down Expand Up @@ -371,13 +372,15 @@ struct EncryptionAndDecryptMultiImpl {
if constexpr (is_sm_mode) {
if (sm4_mode_map.count(mode_str) == 0) {
all_insert_null = true;
} else {
encryption_mode = sm4_mode_map.at(mode_str);
}
encryption_mode = sm4_mode_map.at(mode_str);
} else {
if (aes_mode_map.count(mode_str) == 0) {
all_insert_null = true;
} else {
encryption_mode = aes_mode_map.at(mode_str);
}
encryption_mode = aes_mode_map.at(mode_str);
}
}

Expand Down
3 changes: 3 additions & 0 deletions regression-test/data/query_p0/sql_functions/encryption_digest/test_encryption_function.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,3 +272,6 @@ zhang
-- !sql56 --
zhang

-- !sql57 --
\N

3 changes: 3 additions & 0 deletions ...sion-test/suites/query_p0/sql_functions/encryption_digest/test_encryption_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,4 +226,7 @@ suite("test_encryption_function") {
qt_sql54 """ select aes_decrypt(aes_encrypt(k,k1,k2, "AES_256_CFB"),k1,k2, "AES_256_CFB") from quantile_table2; """
qt_sql55 """ select aes_decrypt(aes_encrypt("zhang",k1,k2, "AES_256_CFB"),k1,k2, "AES_256_CFB") from quantile_table2; """
qt_sql56 """ select aes_decrypt(aes_encrypt("zhang",k1,k2, "AES_256_CFB"),k1,k2, "AES_256_CFB") from quantile_table2; """

//four arg (column/const) with wrong mode
qt_sql57 """ select sm4_decrypt(sm4_encrypt(k,"doris","abcdefghij", "SM4_128_CBC"),"doris","abcdefghij","SM4_555_CBC") from quantile_table2; """
}