Skip to content

[fix](scanner) Fix incorrect _max_thread_num in scanner context #40569 #40760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhiqiang-hhhh wants to merge 2 commits into from
Closed

[fix](scanner) Fix incorrect _max_thread_num in scanner context #40569 #40760

zhiqiang-hhhh wants to merge 2 commits into from

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Sep 12, 2024 •
edited
Loading

cherry pick from #40569 and do modification on branch-2.1

  1. Since constructor changed, so modified code of non-pipeline and old pipeline
  2. The _max_thread_num calculation of old pipeline is not changed.

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Sep 12, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the pick_40569_to_upstream_branch-2.1 branch from bf447d4 to b5b3d64 Compare September 12, 2024 12:17
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the pick_40569_to_upstream_branch-2.1 branch from b5b3d64 to e39b1b2 Compare September 12, 2024 13:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Sep 12, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 12, 2024

TeamCity be ut coverage result:
Function Coverage: 36.15% (9320/25778)
Line Coverage: 27.72% (76468/275904)
Region Coverage: 26.51% (39276/148180)
Branch Coverage: 23.34% (20040/85860)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ead4a5d9455318cc6bc3027542fd627affa2aaf0_ead4a5d9455318cc6bc3027542fd627affa2aaf0/report/index.html

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Sep 13, 2024

failed on known problem

@yiguolei yiguolei closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhiqiang-hhhh @doris-robot @yiguolei