[enhancement]support query when only restoring a few partitions of this table #40768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Johnnyssc
force-pushed
the
fix_restore_effect_query
branch
from
4eee036 to
fc41ec8
Compare
Contributor
Author
|
run buildall |
morrySnow
reviewed
Oct 11, 2024
| // if doing restore with table, throw exception here | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_BAD_TABLE_STATE, "RESTORING"); | ||
| } | ||
| Boolean isAllPartitionRestoring = ((OlapTable) table).getPartitions().stream() |
Contributor
There was a problem hiding this comment.
legacy planner will be remove very soon, so u should impl it in Nereids
Contributor
|
We're closing this PR because it hasn't been updated in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If query execute in one table that is restoring data, query may failed with Exception occasionally.
Exception info :" Table state is not NORMAL: 'RESTORING'".
But mostly restoreJob only effects some partitions in this table, not all of them, so that the other partitions need support query successfully.
The reason why this problem happen occasionally is that
Analyzer.resolveTableRefcheck olapTable.state and partition.state without readLock, so fix it by check partition.state only.ps: set restore status for partitions in this pr:#8245