Skip to content

Conversation

@wuwenchi
Copy link
Contributor

Proposed changes

When a cmd is executed, we can cancel the reference to the executor to release the related resources. Otherwise, these resources can only be released when the next cmd is executed.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42622 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 81b1da9fa901ef997c322f5b5cd7721ad884596e, data reload: false

------ Round 1 ----------------------------------
q1	17619	7222	7168	7168
q2	2037	176	187	176
q3	10682	1248	1362	1248
q4	10157	953	992	953
q5	7711	3136	3120	3120
q6	237	153	155	153
q7	1017	633	614	614
q8	9454	1975	2020	1975
q9	6705	6284	6305	6284
q10	7024	2532	2501	2501
q11	443	255	251	251
q12	416	227	234	227
q13	17760	3022	3067	3022
q14	279	258	255	255
q15	566	537	535	535
q16	523	434	443	434
q17	993	949	944	944
q18	7385	6737	6768	6737
q19	1381	1228	1231	1228
q20	624	337	320	320
q21	3873	3504	3527	3504
q22	1089	1019	973	973
Total cold run time: 107975 ms
Total hot run time: 42622 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7141	7238	7753	7238
q2	337	243	244	243
q3	3089	3095	3039	3039
q4	2125	2123	2041	2041
q5	5733	5637	5703	5637
q6	244	148	153	148
q7	2168	1792	1832	1792
q8	3365	3411	3397	3397
q9	8851	8962	8845	8845
q10	3512	3629	3603	3603
q11	590	494	483	483
q12	843	629	604	604
q13	9289	3238	3256	3238
q14	317	306	285	285
q15	568	532	562	532
q16	540	482	472	472
q17	1803	1780	1764	1764
q18	8545	8143	8174	8143
q19	1777	1762	1752	1752
q20	2115	1911	1919	1911
q21	6112	5681	5781	5681
q22	1118	1019	1056	1019
Total cold run time: 70182 ms
Total hot run time: 61867 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199795 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 81b1da9fa901ef997c322f5b5cd7721ad884596e, data reload: false

query1	1282	894	911	894
query2	6569	1768	1798	1768
query3	12149	4007	3933	3933
query4	63904	25458	23798	23798
query5	4942	533	533	533
query6	291	161	172	161
query7	5497	320	303	303
query8	312	231	232	231
query9	5886	2599	2593	2593
query10	393	282	270	270
query11	16001	15517	15746	15517
query12	160	104	101	101
query13	1423	447	420	420
query14	10310	7225	7254	7225
query15	211	178	183	178
query16	6980	539	509	509
query17	1103	608	591	591
query18	1885	332	303	303
query19	209	162	153	153
query20	120	116	124	116
query21	213	112	109	109
query22	4623	4376	4538	4376
query23	34909	33921	33851	33851
query24	6156	3074	3082	3074
query25	520	421	432	421
query26	617	162	157	157
query27	1573	285	291	285
query28	2802	2098	2079	2079
query29	689	441	431	431
query30	224	166	152	152
query31	972	784	772	772
query32	78	55	63	55
query33	441	323	305	305
query34	906	494	482	482
query35	874	743	750	743
query36	1019	929	908	908
query37	148	87	84	84
query38	4061	3957	4028	3957
query39	1476	1429	1400	1400
query40	209	115	118	115
query41	50	50	47	47
query42	119	97	102	97
query43	512	458	450	450
query44	1172	814	776	776
query45	196	171	173	171
query46	1093	834	813	813
query47	1896	1736	1772	1736
query48	373	297	294	294
query49	750	470	451	451
query50	946	438	438	438
query51	7000	6919	6923	6919
query52	97	88	88	88
query53	258	183	187	183
query54	579	466	472	466
query55	75	78	76	76
query56	286	270	274	270
query57	1218	1102	1068	1068
query58	239	238	260	238
query59	2653	2431	2534	2431
query60	298	281	280	280
query61	107	105	105	105
query62	790	689	670	670
query63	232	189	185	185
query64	1604	675	682	675
query65	3242	3184	3184	3184
query66	670	291	297	291
query67	15953	15612	15282	15282
query68	2068	574	580	574
query69	400	289	279	279
query70	1191	1128	1121	1121
query71	355	281	288	281
query72	6026	4006	4047	4006
query73	763	329	333	329
query74	9417	8973	9390	8973
query75	3333	2750	2713	2713
query76	1383	1297	1306	1297
query77	537	323	343	323
query78	12501	9535	9384	9384
query79	964	882	862	862
query80	985	853	837	837
query81	472	268	265	265
query82	279	264	267	264
query83	190	193	187	187
query84	268	105	107	105
query85	724	414	400	400
query86	337	318	319	318
query87	4590	4405	4317	4317
query88	4183	4103	4104	4103
query89	373	378	372	372
query90	1900	315	304	304
query91	124	121	123	121
query92	81	77	77	77
query93	1072	1046	1040	1040
query94	779	398	364	364
query95	498	425	423	423
query96	475	473	472	472
query97	3171	3142	3127	3127
query98	235	228	228	228
query99	1660	1318	1292	1292
Total cold run time: 305879 ms
Total hot run time: 199795 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.71 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 81b1da9fa901ef997c322f5b5cd7721ad884596e, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.66	0.08	0.08
query5	0.50	0.51	0.50
query6	1.15	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.57	0.52	0.51
query10	0.57	0.59	0.56
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.63	0.60	0.60
query14	1.47	1.45	1.49
query15	0.92	0.88	0.87
query16	0.36	0.37	0.36
query17	1.03	1.04	1.08
query18	0.17	0.16	0.17
query19	1.88	1.75	1.78
query20	0.01	0.01	0.01
query21	15.40	0.67	0.69
query22	3.90	6.27	1.95
query23	17.84	1.34	1.29
query24	2.25	0.22	0.22
query25	0.18	0.08	0.09
query26	0.28	0.19	0.18
query27	0.08	0.07	0.07
query28	13.20	1.13	1.12
query29	12.53	3.34	3.33
query30	0.24	0.05	0.07
query31	2.86	0.42	0.42
query32	3.23	0.50	0.50
query33	3.06	3.06	3.07
query34	15.45	4.33	4.32
query35	4.34	4.33	4.33
query36	0.68	0.49	0.50
query37	0.20	0.16	0.16
query38	0.17	0.15	0.15
query39	0.05	0.04	0.04
query40	0.17	0.14	0.13
query41	0.09	0.06	0.05
query42	0.06	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 107.94 s
Total hot run time: 31.71 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This is not a serious problem because the executor will always be released when executing next command in this session.
But release it actively after on command finish may be better because if this is no more command in this session, the executor will not be released and may occupy memory.

@morrySnow @yiguolei PTAL

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit fdd7ddc into apache:master Sep 18, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
## Proposed changes

When a cmd is executed, we can cancel the reference to the `executor` to
release the related resources. Otherwise, these resources can only be
released when the next cmd is executed.
morningman pushed a commit that referenced this pull request Feb 17, 2025
## Proposed changes

When a cmd is executed, we can cancel the reference to the `executor` to
release the related resources. Otherwise, these resources can only be
released when the next cmd is executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants