-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](mem)Dereference for executor #40800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 42622 ms |
TPC-DS: Total hot run time: 199795 ms |
ClickBench: Total hot run time: 31.71 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is not a serious problem because the executor will always be released when executing next command in this session.
But release it actively after on command finish may be better because if this is no more command in this session, the executor will not be released and may occupy memory.
@morrySnow @yiguolei PTAL
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
## Proposed changes When a cmd is executed, we can cancel the reference to the `executor` to release the related resources. Otherwise, these resources can only be released when the next cmd is executed.
## Proposed changes When a cmd is executed, we can cancel the reference to the `executor` to release the related resources. Otherwise, these resources can only be released when the next cmd is executed.
Proposed changes
When a cmd is executed, we can cancel the reference to the
executorto release the related resources. Otherwise, these resources can only be released when the next cmd is executed.