Skip to content

Conversation

@Vallishp
Copy link
Contributor

Proposed changes

Issue Number: close #xxx
row count skipped in common validation
if table report not done for the all tablet
row count will be -1 if done can get actual data.
So row count can cause timing issue and make testcase unstable.
we already have a checkpoint for rowcount with waiting . in common validation we have skiped rowcount.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 8fe3a36 into apache:master Sep 15, 2024
yiguolei pushed a commit that referenced this pull request Sep 18, 2024
## Proposed changes

Issue Number: close #xxx
backport #40861
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
## Proposed changes

Issue Number: close #xxx
   row count skipped in common validation
   if table report not done for the all tablet 
    row count will be -1 if done can get actual data.
So row count can cause timing issue and make testcase unstable.
we already have a checkpoint for rowcount with waiting . in common
validation we have skiped rowcount.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants