Skip to content

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Sep 14, 2024

Proposed changes

  1. Optimized waitForRollUpJob method in Suite.groovy to make sure roll up is build succesfully before rewirte.
  2. Modify expect rewritten result in agg_sync_mv.groovy

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@seawinde
Copy link
Contributor Author

run buildall

(3, 1, 'o', 33.5, '2023-12-10', 'a', 'b', 1, 'yy'),
(3, 1, 'o', 33.5, '2023-12-10', 'a', 'b', 1, 'yy'),
(3, 1, 'o', 33.5, '2023-12-10', 'a', 'b', 1, 'yy'),
(4, 2, 'o', 43.2, '2023-12-11', 'c','d',2, 'mm'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why update data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Becaus the case is not chosen by CBO stably, add more data to make cbo chose mv easier.
but there is a fix pr #40529 to fix this. Maybe we doesn't need to update data.

@seawinde
Copy link
Contributor Author

run buildall

@seawinde
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit da6ac0c into apache:master Sep 20, 2024
seawinde added a commit to seawinde/doris that referenced this pull request Sep 20, 2024
1. Optimized `waitForRollUpJob` method in `Suite.groovy` to make sure
roll up is build succesfully before rewirte.
2. Modify expect rewritten result in` agg_sync_mv.groovy`
yiguolei pushed a commit that referenced this pull request Sep 20, 2024
seawinde added a commit to seawinde/doris that referenced this pull request Oct 23, 2024
1. Optimized `waitForRollUpJob` method in `Suite.groovy` to make sure
roll up is build succesfully before rewirte.
2. Modify expect rewritten result in` agg_sync_mv.groovy`
dataroaring pushed a commit that referenced this pull request Oct 23, 2024
## Proposed changes

pr: #40871
commitId: da6ac0c

pr: #41145
commitId: 5e6e4bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants