[PipelineX](improvement) Prepare tasks in parallel (#40844) #40874
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) { | ||
| Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request, |
There was a problem hiding this comment.
warning: function 'prepare' exceeds recommended size/complexity thresholds [readability-function-size]
^Additional context
be/src/pipeline/pipeline_fragment_context.cpp:233: 124 lines including whitespace and comments (threshold 80)
^|
|
||
| Status PipelineFragmentContext::_build_pipeline_tasks( | ||
| const doris::TPipelineFragmentParams& request) { | ||
| Status PipelineFragmentContext::_build_pipeline_tasks(const doris::TPipelineFragmentParams& request, |
There was a problem hiding this comment.
warning: function '_build_pipeline_tasks' has cognitive complexity of 56 (threshold 50) [readability-function-cognitive-complexity]
^Additional context
be/src/pipeline/pipeline_fragment_context.cpp:373: nesting level increased to 1
);
^be/src/pipeline/pipeline_fragment_context.cpp:378: nesting level increased to 2
gr;
^be/src/pipeline/pipeline_fragment_context.cpp:384: +3, including nesting penalty of 2, nesting level increased to 3
);
^be/src/pipeline/pipeline_fragment_context.cpp:387: +3, including nesting penalty of 2, nesting level increased to 3
}
^be/src/pipeline/pipeline_fragment_context.cpp:390: +3, including nesting penalty of 2, nesting level increased to 3
}
^be/src/pipeline/pipeline_fragment_context.cpp:393: +3, including nesting penalty of 2, nesting level increased to 3
}
^be/src/pipeline/pipeline_fragment_context.cpp:396: +3, including nesting penalty of 2, nesting level increased to 3
}
^be/src/pipeline/pipeline_fragment_context.cpp:501: nesting level increased to 2
te
^be/src/pipeline/pipeline_fragment_context.cpp:503: +3, including nesting penalty of 2, nesting level increased to 3
]);
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/pipeline_fragment_context.cpp:503: +4, including nesting penalty of 3, nesting level increased to 4
]);
^be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/pipeline_fragment_context.cpp:542: +1, including nesting penalty of 0, nesting level increased to 1
};
^be/src/pipeline/pipeline_fragment_context.cpp:549: +2, including nesting penalty of 1, nesting level increased to 2
0;
^be/src/pipeline/pipeline_fragment_context.cpp:550: +3, including nesting penalty of 2, nesting level increased to 3
) {
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/pipeline_fragment_context.cpp:550: nesting level increased to 4
) {
^be/src/pipeline/pipeline_fragment_context.cpp:555: +5, including nesting penalty of 4, nesting level increased to 5
++;
^be/src/pipeline/pipeline_fragment_context.cpp:550: +4, including nesting penalty of 3, nesting level increased to 4
) {
^be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/pipeline_fragment_context.cpp:561: +2, including nesting penalty of 1, nesting level increased to 2
m);
^be/src/pipeline/pipeline_fragment_context.cpp:563: +3, including nesting penalty of 2, nesting level increased to 3
k);
^be/src/pipeline/pipeline_fragment_context.cpp:564: +4, including nesting penalty of 3, nesting level increased to 4
) {
^be/src/pipeline/pipeline_fragment_context.cpp:569: +1, nesting level increased to 1
}
^be/src/pipeline/pipeline_fragment_context.cpp:570: +2, including nesting penalty of 1, nesting level increased to 2
e {
^be/src/pipeline/pipeline_fragment_context.cpp:571: +3, including nesting penalty of 2, nesting level increased to 3
) {
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/pipeline_fragment_context.cpp:571: +4, including nesting penalty of 3, nesting level increased to 4
) {
^be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^|
|
||
| Status PipelineFragmentContext::_build_pipeline_tasks( | ||
| const doris::TPipelineFragmentParams& request) { | ||
| Status PipelineFragmentContext::_build_pipeline_tasks(const doris::TPipelineFragmentParams& request, |
There was a problem hiding this comment.
warning: function '_build_pipeline_tasks' exceeds recommended size/complexity thresholds [readability-function-size]
^Additional context
be/src/pipeline/pipeline_fragment_context.cpp:360: 218 lines including whitespace and comments (threshold 80)
^
2 participants
Proposed changes
pick #40844