Skip to content

Conversation

@yiguolei
Copy link
Contributor

Proposed changes

pick
#39536
#39913
#39964
#40020

yiguolei and others added 4 commits September 15, 2024 23:53
…pache#39536)

It is needed to pick to branch 21, because we will depend on it to do
spill disk.

Co-authored-by: yiguolei <yiguolei@gmail.com>
…pache#39913)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

---------

Co-authored-by: yiguolei <yiguolei@gmail.com>
…age builder allocate memory failed (apache#39964)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

---------

Co-authored-by: yiguolei <yiguolei@gmail.com>
…ate memory failed (apache#40020)

1. pageio method should return error when allocate memory failed just
for point query.
2. variant parsing logic should return error when allocate memory
failed.

---------

Co-authored-by: yiguolei <yiguolei@gmail.com>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


Status PageIO::read_and_decompress_page(const PageReadOptions& opts, PageHandle* handle,
Slice* body, PageFooterPB* footer) {
Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle* handle,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'read_and_decompress_page_' exceeds recommended size/complexity thresholds [readability-function-size]

Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle* handle,
               ^
Additional context

be/src/olap/rowset/segment_v2/page_io.cpp:113: 115 lines including whitespace and comments (threshold 80)

Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle* handle,
               ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9328/25794)
Line Coverage: 27.73% (76653/276433)
Region Coverage: 26.51% (39362/148474)
Branch Coverage: 23.31% (20041/85994)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9351ecec52cf3764f7501c48ee73715a58d8a095_9351ecec52cf3764f7501c48ee73715a58d8a095/report/index.html

@yiguolei yiguolei merged commit a6e2364 into apache:branch-2.1 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants