Skip to content

Fix some problem related with publish version task #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaoyli merged 9 commits into from
Jul 23, 2020
Merged

Fix some problem related with publish version task #4089

chaoyli merged 9 commits into from
Jul 23, 2020

Conversation

@caiconghui
Copy link
Contributor

@caiconghui caiconghui commented Jul 13, 2020 •
edited by morningman
Loading

This PR is mainly do following three things:

  1. Add thread name in fe log to make trace problem more easy.
  2. Add agent_task_resend_wait_time_ms config to escape sending duplicate agent task to be.
  3. Skip to continue to update replica version when new version is lower than replica version in fe.

@caiconghui
Copy link
Contributor Author

caiconghui commented Jul 13, 2020

fix #4090

yangzhg
yangzhg reviewed Jul 15, 2020
View reviewed changes
@yangzhg yangzhg added the kind/fix Categorizes issue or PR as related to a bug. label Jul 15, 2020
morningman
morningman reviewed Jul 15, 2020
View reviewed changes
@morningman morningman self-assigned this Jul 15, 2020
@caiconghui caiconghui requested a review from morningman July 20, 2020 03:01
morningman
morningman previously approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

morningman commented Jul 22, 2020

Hi @caiconghui , the FE code structure has been changed, please rebase the code to solve the conflicts

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 23, 2020
@chaoyli chaoyli merged commit 2334f5d into apache:master Jul 23, 2020
@caiconghui caiconghui deleted the fix-warn branch July 30, 2020 02:21
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
@Yukang-Lian
[Enhancement](Compaction) Add some metrics for compaction (apache#51649…
8f59cd7 
…) (apache#4089)

Pick from doris apache#51649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhg yangzhg yangzhg left review comments

@chaoyli chaoyli chaoyli approved these changes

@morningman morningman morningman left review comments

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@caiconghui @morningman @yangzhg @chaoyli