[enhancement](nereids)show user friendly error msg when window function contains order by expression #40937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on contains order by expression
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41591 ms |
TPC-H: Total hot run time: 41075 ms |
TPC-DS: Total hot run time: 199027 ms |
ClickBench: Total hot run time: 31.76 s |
morrySnow
approved these changes
Sep 20, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
feiniaofeiafei
approved these changes
Sep 20, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ains order by expression (#40937)
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Mar 5, 2025
…48492) ### What problem does this PR solve? Related PR: #40937 Problem Summary: We want to provide clearer error messages for window functions with ORDER BY parameters. However, the current error checking incorrectly inspects all child nodes instead of just the immediate/direct child nodes. As a result, when nested window functions are present, this may trigger unexpected error reporting. ```sql errCode = 2, detailMessage = order by is not supported in max(dense_rank() WindowSpec(PARTITION BY lot_no#0 ORDER BY loading_time#20 asc null first)) ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
…48492) ### What problem does this PR solve? Related PR: #40937 Problem Summary: We want to provide clearer error messages for window functions with ORDER BY parameters. However, the current error checking incorrectly inspects all child nodes instead of just the immediate/direct child nodes. As a result, when nested window functions are present, this may trigger unexpected error reporting. ```sql errCode = 2, detailMessage = order by is not supported in max(dense_rank() WindowSpec(PARTITION BY lot_no#0 ORDER BY loading_time#20 asc null first)) ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
…48492) ### What problem does this PR solve? Related PR: #40937 Problem Summary: We want to provide clearer error messages for window functions with ORDER BY parameters. However, the current error checking incorrectly inspects all child nodes instead of just the immediate/direct child nodes. As a result, when nested window functions are present, this may trigger unexpected error reporting. ```sql errCode = 2, detailMessage = order by is not supported in max(dense_rank() WindowSpec(PARTITION BY lot_no#0 ORDER BY loading_time#20 asc null first)) ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pache#48492) ### What problem does this PR solve? Related PR: apache#40937 Problem Summary: We want to provide clearer error messages for window functions with ORDER BY parameters. However, the current error checking incorrectly inspects all child nodes instead of just the immediate/direct child nodes. As a result, when nested window functions are present, this may trigger unexpected error reporting. ```sql errCode = 2, detailMessage = order by is not supported in max(dense_rank() WindowSpec(PARTITION BY lot_no#0 ORDER BY loading_time#20 asc null first)) ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Proposed changes
Issue Number: close #xxx