show lost tabletIds which do not have any available replica#4095
show lost tabletIds which do not have any available replica#4095spaces-X wants to merge 1 commit intoapache:masterfrom spaces-X:lostTablet
Conversation
|
Compile failed: |
| this.unhealthyTabletIds = unhealthyTabletIds; | ||
| this.inconsistentTabletIds = inconsistentTabletIds; | ||
| this.cloningTabletIds = cloningTabletIds; | ||
| this.noavlreplicaTabletIds = noavlreplicaTabletIds; |
There was a problem hiding this comment.
| this.noavlreplicaTabletIds = noavlreplicaTabletIds; | |
| this.noAvlreplicaTabletIds = noAvlreplicaTabletIds; |
| } | ||
|
|
||
| // find tablet with no available replica; | ||
| if (!tablet.hasAvailableReplica(infoService, partition.getVisibleVersion(), |
There was a problem hiding this comment.
I think we can just add a new enum value in TabletStatus, for example, NO_AVAILABLE_REPLICA, and return it by calling getHealthStatusWithPriority() above. So that we can save some iteration.
But adding new enum value in TabletStatus may affect other code, which is uncontrollable. So I suggest to add a new parameter in getHealthStatusWithPriority(), eg, getHealthStatusWithPriority(..., bool returnNoAvlExplicit).
And if returnNoAvlExplicit is true, it return return NO_AVAILABLE_REPLICA explicit.
|
Done @morningman |
|
HI @spaces-X the FE code structure has been change, please rebase the code the solve the conflicts. |
|
This is already supported #6045 |
2 participants
Add tabletIds without available replica in system info page, to improve the monitoring information.