-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](scanner) lazy update block mem usage when status is not ok #40953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41465 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 199312 ms |
ClickBench: Total hot run time: 33.38 s |
zhiqiang-hhhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…che#40953) fix problem like this: ``` set enable_common_expr_pushdown=false; create table t(a int, c varchar(1024)) PROPERTIES ("replication_allocation" = "tag.location.default: 1"); insert into t values(1, "a b c d e"); SELECT count() FROM t where c MATCH_PHRASE_EDGE 's'; I20240919 09:31:40.713896 2224044 internal_service.cpp:626] Cancel query 3e48a306704f4691-840d239bf31420aa, reason: [INTERNAL_ERROR]PStatus: (127.0.0.1)[INTERNAL_ERROR]Column match_phrase_edge({"c", "String"}) in block is nullptr, in method bytes. All Columns are c String match_phrase_edge({"c", "String"}) 3# doris::vectorized::Block::allocated_bytes() const at be/src/vec/core/block.cpp:446 4# doris::vectorized::ScannerScheduler::_scanner_scan(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>) at be/src/vec/exec/scan/scanner_scheduler.cpp:243 ```
) ## Proposed changes fix problem like this: ``` set enable_common_expr_pushdown=false; create table t(a int, c varchar(1024)) PROPERTIES ("replication_allocation" = "tag.location.default: 1"); insert into t values(1, "a b c d e"); SELECT count() FROM t where c MATCH_PHRASE_EDGE 's'; I20240919 09:31:40.713896 2224044 internal_service.cpp:626] Cancel query 3e48a306704f4691-840d239bf31420aa, reason: [INTERNAL_ERROR]PStatus: (127.0.0.1)[INTERNAL_ERROR]Column match_phrase_edge({"c", "String"}) in block is nullptr, in method bytes. All Columns are c String match_phrase_edge({"c", "String"}) 3# doris::vectorized::Block::allocated_bytes() const at be/src/vec/core/block.cpp:446 4# doris::vectorized::ScannerScheduler::_scanner_scan(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>) at be/src/vec/exec/scan/scanner_scheduler.cpp:243 ```
Proposed changes
fix problem like this: