[fix](Nereids) fix leading tag can not work when leading is used #40958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morrySnow
reviewed
Sep 19, 2024
| CascadesContext outerCascadesCtx = CascadesContext.newContextWithCteContext( | ||
| ctx.cascadesContext, logicalCTE.child(), result.first); | ||
| outerCascadesCtx.newAnalyzer().analyze(); | ||
| ctx.cascadesContext.setLeadingDisableJoinReorder(outerCascadesCtx.isLeadingDisableJoinReorder()); |
TPC-H: Total hot run time: 41958 ms |
TPC-DS: Total hot run time: 194491 ms |
ClickBench: Total hot run time: 31.94 s |
LiBinfeng-01
force-pushed
the
fix_leading_tag
branch
from
e45cb1d to
f070eea
Compare
Contributor
Author
|
run buildall |
LiBinfeng-01
force-pushed
the
fix_leading_tag
branch
from
f070eea to
ac7ac65
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
LiBinfeng-01
force-pushed
the
fix_leading_tag
branch
from
ac7ac65 to
f7b6ac9
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run feut |
Contributor
Author
|
run external |
Contributor
Author
|
run cloud_p0 |
1 similar comment
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
Author
|
run compile |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
morrySnow
previously approved these changes
Oct 10, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
force-pushed
the
fix_leading_tag
branch
from
6510e87 to
26479ca
Compare
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
englefly
approved these changes
Oct 14, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
morrySnow
approved these changes
Oct 14, 2024
qzsee
pushed a commit
to qzsee/incubator-doris
that referenced
this pull request
Oct 16, 2024
…che#40958) isLeading in cascade context means do we have leading in this scope isLeadingDisableJoinReorder means does leading used we need to copy it after analyze outerside of cte
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 16, 2024
…che#40958) isLeading in cascade context means do we have leading in this scope isLeadingDisableJoinReorder means does leading used we need to copy it after analyze outerside of cte
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 17, 2024
…che#40958) isLeading in cascade context means do we have leading in this scope isLeadingDisableJoinReorder means does leading used we need to copy it after analyze outerside of cte
morrySnow
pushed a commit
that referenced
this pull request
Oct 17, 2024
…#41869) pick: #35925 #39715 #40167 #40958 Add feat of force use/nouse cbo rule hint and fix pr introduce when not using this hint, cbo rules like INFER_SET_OPERATOR_DISTINCT would generate two plans and compare their cost and nereids optimizer would decide which is better. But when we want to control the behavior of cbo rules we could use this force cbo rule hint usage example explain shape plan select /*+ USE_CBO_RULE(INFER_SET_OPERATOR_DISTINCT) */ * from t1 union select * from t2; the USE_CBO_RULE(INFER_SET_OPERATOR_DISTINCT) hint would force rule INFER_SET_OPERATOR_DISTINCT to be used and generate plan like, which hashAgg below union is generated by this rule: -- !with_hint_union_distinct -- ----hashAgg[GLOBAL] --------hashAgg[LOCAL] ----------PhysicalUnion --------------hashAgg[LOCAL] ----------------PhysicalOlapScan[t1] --------------hashAgg[LOCAL] ----------------PhysicalOlapScan[t2] Hint log: Used: INFER_SET_OPERATOR_DISTINCT UnUsed: SyntaxError: When we want to force disable this rule, we could use explain shape plan select /*+ NO_USE_CBO_RULE(INFER_SET_OPERATOR_DISTINCT) */ * from t1 union select * from t2; which would generate plan with this rule: -- !with_hint_no_union_distinct -- ----hashAgg[GLOBAL] --------hashAgg[LOCAL] ----------PhysicalUnion --------------PhysicalOlapScan[t1] --------------PhysicalOlapScan[t2] Hint log: Used: NO_INFER_SET_OPERATOR_DISTINCT UnUsed: SyntaxError: change sessionvariable enableNereidsRules to varType.remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLeading in cascade context means do we have leading in this scope
isLeadingDisableJoinReorder means does leading used
we need to copy it after analyze outerside of cte