Skip to content

[fix](sys_table) fix potential NPE when query table_properties and partitions sys table #40972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Sep 20, 2024
Merged

[fix](sys_table) fix potential NPE when query table_properties and partitions sys table #40972

morningman merged 2 commits into from
Sep 20, 2024

Conversation

@Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Sep 19, 2024

Proposed changes

Issue Number: close #xxx

fix potential NPE when query table_properties and partitions sys table
follow up for #40944

@doris-robot
Copy link

doris-robot commented Sep 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

Vallishp commented Sep 19, 2024

run buildall

@Vallishp Vallishp force-pushed the systable_protect_olap branch from 1db7816 to 10a7725 Compare September 19, 2024 06:37
@Vallishp
Copy link
Contributor Author

Vallishp commented Sep 19, 2024

run buildall

morningman
morningman approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 19, 2024

TPC-H: Total hot run time: 41579 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 10a77253d90474678681e1b55ac6f39d4c3f369d, data reload: false

------ Round 1 ----------------------------------
q1	17959	7821	7246	7246
q2	2053	162	157	157
q3	10674	1092	1187	1092
q4	10297	722	776	722
q5	7755	3090	3116	3090
q6	234	147	147	147
q7	1023	620	612	612
q8	9456	2090	2047	2047
q9	6822	6380	6447	6380
q10	6994	2301	2348	2301
q11	434	247	248	247
q12	415	214	213	213
q13	17783	2983	2971	2971
q14	251	228	216	216
q15	573	518	523	518
q16	680	626	615	615
q17	986	847	855	847
q18	7475	6738	6573	6573
q19	1391	1033	1090	1033
q20	593	296	279	279
q21	3979	3312	3261	3261
q22	1100	1012	1014	1012
Total cold run time: 108927 ms
Total hot run time: 41579 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7258	7207	7172	7172
q2	334	231	226	226
q3	3066	3018	2947	2947
q4	2077	1889	1841	1841
q5	5646	5626	5661	5626
q6	236	146	143	143
q7	2201	1767	1758	1758
q8	3343	3476	3431	3431
q9	8743	8921	8812	8812
q10	3516	3409	3510	3409
q11	585	489	489	489
q12	802	593	603	593
q13	11920	3194	3170	3170
q14	322	281	278	278
q15	569	511	522	511
q16	710	676	676	676
q17	1799	1611	1605	1605
q18	8220	7917	7818	7818
q19	1745	1624	1577	1577
q20	2119	1897	1864	1864
q21	5551	5346	5437	5346
q22	1162	1085	1055	1055
Total cold run time: 71924 ms
Total hot run time: 60347 ms

@doris-robot
Copy link

doris-robot commented Sep 19, 2024

TPC-DS: Total hot run time: 195486 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 10a77253d90474678681e1b55ac6f39d4c3f369d, data reload: false

query1	1267	869	896	869
query2	6365	2094	2070	2070
query3	10781	3995	3982	3982
query4	63565	27209	23442	23442
query5	5087	468	471	468
query6	417	168	166	166
query7	5509	304	295	295
query8	337	228	220	220
query9	8676	2674	2637	2637
query10	450	283	272	272
query11	17840	15306	15747	15306
query12	151	106	98	98
query13	1507	419	418	418
query14	10865	7367	7620	7367
query15	208	179	175	175
query16	7024	470	477	470
query17	1232	599	594	594
query18	1714	321	316	316
query19	237	153	155	153
query20	130	117	109	109
query21	211	103	108	103
query22	4877	4699	4896	4699
query23	34398	33801	33911	33801
query24	5989	2893	2905	2893
query25	523	420	404	404
query26	631	163	160	160
query27	1643	285	289	285
query28	4270	2466	2427	2427
query29	673	432	432	432
query30	240	154	152	152
query31	969	794	811	794
query32	74	53	55	53
query33	412	308	300	300
query34	882	495	490	490
query35	843	736	719	719
query36	1083	941	962	941
query37	147	84	81	81
query38	3969	3855	3902	3855
query39	1507	1407	1409	1407
query40	201	95	96	95
query41	47	44	51	44
query42	120	94	98	94
query43	542	502	501	501
query44	1139	826	797	797
query45	190	163	166	163
query46	1133	746	834	746
query47	1988	1865	1854	1854
query48	457	352	376	352
query49	702	397	402	397
query50	843	404	419	404
query51	7055	6819	6927	6819
query52	96	84	85	84
query53	244	178	180	178
query54	562	446	444	444
query55	75	70	73	70
query56	282	259	251	251
query57	1235	1119	1079	1079
query58	219	219	234	219
query59	3184	3130	3017	3017
query60	297	285	251	251
query61	107	102	105	102
query62	758	643	647	643
query63	214	185	181	181
query64	1721	655	644	644
query65	3229	3157	3169	3157
query66	635	292	298	292
query67	15868	15508	15603	15508
query68	4375	597	576	576
query69	433	287	287	287
query70	1198	1050	1055	1050
query71	355	265	279	265
query72	6398	3967	3991	3967
query73	781	328	330	328
query74	9482	9012	8927	8927
query75	3373	2641	2664	2641
query76	1801	931	942	931
query77	476	293	277	277
query78	10112	9242	9267	9242
query79	1164	546	543	543
query80	896	435	430	430
query81	547	242	237	237
query82	1382	141	142	141
query83	237	137	140	137
query84	287	74	75	74
query85	890	290	271	271
query86	347	302	267	267
query87	4500	4316	4201	4201
query88	3566	2370	2340	2340
query89	398	279	277	277
query90	1900	183	182	182
query91	196	147	147	147
query92	62	46	45	45
query93	1680	537	532	532
query94	747	282	284	282
query95	347	252	255	252
query96	605	278	283	278
query97	3240	3116	3087	3087
query98	212	206	204	204
query99	1555	1259	1264	1259
Total cold run time: 313388 ms
Total hot run time: 195486 ms

@doris-robot
Copy link

doris-robot commented Sep 19, 2024

ClickBench: Total hot run time: 32.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 10a77253d90474678681e1b55ac6f39d4c3f369d, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.10	0.11
query5	0.52	0.50	0.49
query6	1.13	0.71	0.74
query7	0.02	0.01	0.01
query8	0.04	0.02	0.03
query9	0.56	0.50	0.49
query10	0.55	0.58	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.58	0.58
query14	2.96	3.01	3.05
query15	0.90	0.81	0.81
query16	0.38	0.36	0.39
query17	1.01	1.01	0.99
query18	0.19	0.19	0.20
query19	1.80	1.74	1.92
query20	0.02	0.01	0.01
query21	15.38	0.59	0.56
query22	2.52	1.90	2.33
query23	17.39	0.81	0.78
query24	2.75	1.02	1.48
query25	0.25	0.13	0.04
query26	0.60	0.14	0.13
query27	0.05	0.04	0.04
query28	10.38	1.08	1.07
query29	12.55	3.22	3.19
query30	0.25	0.06	0.06
query31	2.88	0.39	0.40
query32	3.25	0.46	0.46
query33	2.99	2.98	3.04
query34	16.91	4.35	4.33
query35	4.42	4.40	4.41
query36	0.66	0.48	0.48
query37	0.09	0.05	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.67 s
Total hot run time: 32.52 s

@Vallishp
Copy link
Contributor Author

Vallishp commented Sep 19, 2024

run buildall

@morningman morningman merged commit 922bee2 into apache:master Sep 20, 2024
@Vallishp Vallishp mentioned this pull request Sep 20, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 20, 2024
@Vallishp
[cherry-pick](branch-2.1)[fix](sys_table) fix potential NPE when quer…
ff22059 
…y table_properties and partitions sys table (#41081)

## Proposed changes

Issue Number: close #xxx

bp #40972
morningman pushed a commit to morningman/doris that referenced this pull request Sep 25, 2024
@Vallishp @morningman
[fix](sys_table) fix potential NPE when query table_properties and pa…
2bff30a 
…rtitions sys table (apache#40972)

## Proposed changes

Issue Number: close #xxx

 fix potential NPE when query table_properties and partitions sys table
follow up for apache#40944
gavinchou pushed a commit that referenced this pull request Sep 25, 2024
@morningman @Vallishp
@BePPPower @CalvinKirs
[pick] pick some pr to fix unstable test cases (#41148) (#41006) (#40944
0d625e2 
) (#40972) (#40553) (#40198) (#40905) (#40757) (#41265)

[fix](systable) fix unstable case for partitions table (#40553)
[fix](sys_table) fix potential NPE when query table_properties and
partitions sys table (#40972)
[fix](table_options) fix potential NPE when quering table_options sys
table (#40944)
[fix](test-case) fix unstable test case about table_options sys table
(#41006)
    [fix](external-p2) ignore external p2 cases (#41148)
    [fix](export) fix p2 tests of export (#40198)
[Fix](test)Fixing Kerberos Principal Not Mapping Correctly to a Local
User (#40905)
[chore](test)Exclude Hive-related packages from `java-udf-src`. (#40757)

---------

Co-authored-by: Vallish Pai <vallishpai@gmail.com>
Co-authored-by: Tiewei Fang <43782773+BePPPower@users.noreply.github.com>
Co-authored-by: Calvin Kirs <kirs@apache.org>
@morningman morningman mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Vallishp @doris-robot @morningman @wuwenchi @gavinchou @yiguolei