Skip to content

[Opt](load) Optimize the error messages of -235 and -238 for loading #41048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 2 commits into from
Sep 28, 2024
Merged

[Opt](load) Optimize the error messages of -235 and -238 for loading #41048

liaoxin01 merged 2 commits into from
Sep 28, 2024

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Sep 20, 2024

No description provided.

@doris-robot
Copy link

doris-robot commented Sep 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@liaoxin01
Copy link
Contributor Author

liaoxin01 commented Sep 20, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 20, 2024

TeamCity be ut coverage result:
Function Coverage: 37.28% (9597/25744)
Line Coverage: 28.67% (79322/276704)
Region Coverage: 28.13% (41053/145961)
Branch Coverage: 24.75% (20912/84508)
Coverage Report: http://coverage.selectdb-in.cc/coverage/be8de68427c171384457cd7425da1c0026c9892f_be8de68427c171384457cd7425da1c0026c9892f/report/index.html

dataroaring
dataroaring reviewed Sep 24, 2024
View reviewed changes
dataroaring
dataroaring approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

PR approved by anyone and no changes requested.

@dataroaring
Copy link
Contributor

dataroaring commented Sep 26, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 26, 2024

TeamCity be ut coverage result:
Function Coverage: 37.31% (9635/25823)
Line Coverage: 28.72% (79746/277663)
Region Coverage: 28.14% (41226/146504)
Branch Coverage: 24.76% (20989/84764)
Coverage Report: http://coverage.selectdb-in.cc/coverage/405d5693fc837aa89d8dcf168f41a697affea846_405d5693fc837aa89d8dcf168f41a697affea846/report/index.html

sollhui
sollhui approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01
Copy link
Contributor Author

liaoxin01 commented Sep 27, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 27, 2024

TeamCity be ut coverage result:
Function Coverage: 37.30% (9627/25811)
Line Coverage: 28.71% (79689/277600)
Region Coverage: 28.13% (41188/146435)
Branch Coverage: 24.74% (20968/84748)
Coverage Report: http://coverage.selectdb-in.cc/coverage/405d5693fc837aa89d8dcf168f41a697affea846_405d5693fc837aa89d8dcf168f41a697affea846/report/index.html

@liaoxin01 liaoxin01 merged commit b6b8e4f into apache:master Sep 28, 2024
@liaoxin01 liaoxin01 deleted the opt_error branch September 28, 2024 11:33
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@liaoxin01 @dataroaring
[Opt](load) Optimize the error messages of -235 and -238 for loading (#…
66c4d1f 
…41048)
@liaoxin01 liaoxin01 mentioned this pull request Oct 10, 2024
Merged
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
cd746fa 
…pache#41048)
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
41e93af 
…pache#41048)
@liaoxin01 liaoxin01 mentioned this pull request Oct 10, 2024
Merged
dataroaring pushed a commit that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading #…
49b1ada 
…41048 (#41645)

cherry pick from #41048
dataroaring pushed a commit that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading #…
a26079c 
…41048 (#41638)

cherry pick from #41048
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@liaoxin01 @cjj2010
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
d88c56c 
…pache#41048)
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
0db0831 
…pache#41048)
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@sollhui sollhui sollhui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liaoxin01 @doris-robot @dataroaring @sollhui