Skip to content

Conversation

@luwei16
Copy link
Contributor

@luwei16 luwei16 commented Sep 20, 2024

problem

insert into t1 (k1,  k2,  v1) value(1, '', 2);
delete form t1 where k1 = 1 and k2 = '';
alter table modify column v1 string
select * from t1 //  expect 0 rows in return, but get 1 row.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 20, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.25% (9598/25769)
Line Coverage: 28.62% (79291/277031)
Region Coverage: 28.09% (41045/146100)
Branch Coverage: 24.72% (20910/84588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ebd04dbb901706c73de6256524d8907603d85a75_ebd04dbb901706c73de6256524d8907603d85a75/report/index.html

@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9607/25772)
Line Coverage: 28.67% (79483/277234)
Region Coverage: 28.12% (41107/146197)
Branch Coverage: 24.75% (20950/84640)
Coverage Report: http://coverage.selectdb-in.cc/coverage/80ce5b9bae03f59a1cce76683d5dd634ef47e1e6_80ce5b9bae03f59a1cce76683d5dd634ef47e1e6/report/index.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add an empty file, just use result = sql """ to check result.

time 600
}

qt_select "select * from ${tableName}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use result = sql """ to get rid of empty .out file.

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 24, 2024

run p0

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 25, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9623/25808)
Line Coverage: 28.70% (79642/277488)
Region Coverage: 28.11% (41160/146427)
Branch Coverage: 24.75% (20973/84728)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6e93479bdc4debee2b5072b17f5882116bdb753e_6e93479bdc4debee2b5072b17f5882116bdb753e/report/index.html

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 25, 2024

run cloud_p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit b0c41df into apache:master Sep 26, 2024
dataroaring pushed a commit that referenced this pull request Sep 26, 2024
…t with empty strings during schema change (#41064)

### problem 
```
insert into t1 (k1,  k2,  v1) value(1, '', 2);
delete form t1 where k1 = 1 and k2 = '';
alter table modify column v1 string
select * from t1 //  expect 0 rows in return, but get 1 row.
```
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
luwei16 added a commit to luwei16/Doris that referenced this pull request Oct 24, 2024
…t with empty strings during schema change (apache#41064)

```
insert into t1 (k1,  k2,  v1) value(1, '', 2);
delete form t1 where k1 = 1 and k2 = '';
alter table modify column v1 string
select * from t1 //  expect 0 rows in return, but get 1 row.
```
yiguolei pushed a commit that referenced this pull request Oct 24, 2024
…t with empty strings during schema change (#41064) (#42427)

```
insert into t1 (k1,  k2,  v1) value(1, '', 2);
delete form t1 where k1 = 1 and k2 = '';
alter table modify column v1 string
select * from t1 //  expect 0 rows in return, but get 1 row.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants