-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](schema change) fix delete predicate incorrect comparisons result with empty strings during schema change #41064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t with empty strings during schema change
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add an empty file, just use result = sql """ to check result.
| time 600 | ||
| } | ||
|
|
||
| qt_select "select * from ${tableName}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use result = sql """ to get rid of empty .out file.
|
run p0 |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run cloud_p0 |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…t with empty strings during schema change (#41064) ### problem ``` insert into t1 (k1, k2, v1) value(1, '', 2); delete form t1 where k1 = 1 and k2 = ''; alter table modify column v1 string select * from t1 // expect 0 rows in return, but get 1 row. ```
…t with empty strings during schema change (apache#41064) ``` insert into t1 (k1, k2, v1) value(1, '', 2); delete form t1 where k1 = 1 and k2 = ''; alter table modify column v1 string select * from t1 // expect 0 rows in return, but get 1 row. ```
problem