Skip to content

[fix](compile)fix mac compile : std no member numbers error. #41075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Sep 21, 2024
Merged

[fix](compile)fix mac compile : std no member numbers error. #41075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions be/src/vec/functions/math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,12 @@ class FunctionNormalCdf : public IFunction {

static bool check_argument(double sd) { return sd > 0; }
static double calculate_cell(double mean, double sd, double v) {
#ifdef __APPLE__
const double sqrt2 = std::sqrt(2);
#else
constexpr double sqrt2 = std::numbers::sqrt2;
#endif

return 0.5 * (std::erf((v - mean) / (sd * sqrt2)) + 1);
}
};
Expand Down