Skip to content

[fix](function) fix error result in auto partition name #41130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 1 commit into from
Sep 26, 2024
Merged

[fix](function) fix error result in auto partition name #41130

zhangstar333 merged 1 commit into from
Sep 26, 2024

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Sep 23, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

list partitions support NULL columns as partition columns

Before:

mysql> select auto_partition_name('list','wyx','null');
+-------------------------------------------------------------+
| auto_partition_name('list','wyx','null')                    |
+-------------------------------------------------------------+
| NULL                                                        |
+-------------------------------------------------------------+

Now:

mysql> select auto_partition_name('list','wyx','null');
+-------------------------------------------------------------+
| auto_partition_name('list','wyx','null')                    |
+-------------------------------------------------------------+
| pwyx3X                                                      |
+-------------------------------------------------------------+

@doris-robot
Copy link

doris-robot commented Sep 23, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wyxxxcat wyxxxcat force-pushed the auto_partition_name_null_value branch from 2ffdb85 to 0ca3187 Compare September 23, 2024 12:35
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 23, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 23, 2024

TeamCity be ut coverage result:
Function Coverage: 37.27% (9607/25775)
Line Coverage: 28.68% (79508/277208)
Region Coverage: 28.13% (41127/146199)
Branch Coverage: 24.78% (20970/84632)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0ca31878192c0c2ef4be72e80439866132acca0f_0ca31878192c0c2ef4be72e80439866132acca0f/report/index.html

@wyxxxcat wyxxxcat force-pushed the auto_partition_name_null_value branch 3 times, most recently from d55ba35 to ac24c38 Compare September 25, 2024 02:57
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 25, 2024

TeamCity be ut coverage result:
Function Coverage: 37.32% (9623/25787)
Line Coverage: 28.73% (79657/277305)
Region Coverage: 28.15% (41177/146256)
Branch Coverage: 24.78% (20982/84658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ac24c380a7df511f4d4c28c29bb1399065272576_ac24c380a7df511f4d4c28c29bb1399065272576/report/index.html

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 25, 2024

TeamCity be ut coverage result:
Function Coverage: 37.29% (9625/25809)
Line Coverage: 28.70% (79649/277512)
Region Coverage: 28.12% (41182/146438)
Branch Coverage: 24.77% (20986/84738)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ac24c380a7df511f4d4c28c29bb1399065272576_ac24c380a7df511f4d4c28c29bb1399065272576/report/index.html

@wyxxxcat wyxxxcat force-pushed the auto_partition_name_null_value branch from ac24c38 to 5a7272a Compare September 25, 2024 12:41
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 25, 2024

TeamCity be ut coverage result:
Function Coverage: 37.28% (9623/25812)
Line Coverage: 28.69% (79620/277521)
Region Coverage: 28.12% (41176/146444)
Branch Coverage: 24.76% (20978/84740)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5a7272abd9df16eed9aa97cb1425206e7d8a64ee_5a7272abd9df16eed9aa97cb1425206e7d8a64ee/report/index.html

zclllyybb
zclllyybb approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR approved by at least one committer and no changes requested.

@zhangstar333 zhangstar333 merged commit a07a134 into apache:master Sep 26, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@wyxxxcat @dataroaring
[fix](function) fix error result in auto partition name (#41130)
249cc05 
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

list partitions support NULL columns as partition columns

Before:
```
mysql> select auto_partition_name('list','wyx','null');
+-------------------------------------------------------------+
| auto_partition_name('list','wyx','null')                    |
+-------------------------------------------------------------+
| NULL                                                        |
+-------------------------------------------------------------+
```
Now:
```
mysql> select auto_partition_name('list','wyx','null');
+-------------------------------------------------------------+
| auto_partition_name('list','wyx','null')                    |
+-------------------------------------------------------------+
| pwyx3X                                                      |
+-------------------------------------------------------------+
```
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@wyxxxcat @cjj2010
[fix](function) fix error result in auto partition name (apache#41130)
3a9d7ab 
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

list partitions support NULL columns as partition columns

Before:
```
mysql> select auto_partition_name('list','wyx','null');
+-------------------------------------------------------------+
| auto_partition_name('list','wyx','null')                    |
+-------------------------------------------------------------+
| NULL                                                        |
+-------------------------------------------------------------+
```
Now:
```
mysql> select auto_partition_name('list','wyx','null');
+-------------------------------------------------------------+
| auto_partition_name('list','wyx','null')                    |
+-------------------------------------------------------------+
| pwyx3X                                                      |
+-------------------------------------------------------------+
```
@wyxxxcat wyxxxcat mentioned this pull request Nov 14, 2024
Merged
yiguolei pushed a commit that referenced this pull request Nov 15, 2024
@wyxxxcat @zclllyybb
[branch-2.1](function) fix error result in auto partition name (#41130)…
edd9015 
… (#43977)

pick #41130
#41372

---------

Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat @doris-robot @zclllyybb @zhangstar333 @yiguolei @dataroaring