[fix](ES Catalog)Only like on keyword can be applied to wildcard query #41176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
xiaokang
reviewed
Sep 24, 2024
Contributor
xiaokang
left a comment
xiaokang
left a comment
There was a problem hiding this comment.
Do you have a end to end testcase for text_field LIKE xxx ?
xiaokang
reviewed
Sep 24, 2024
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
qidaye
force-pushed
the
fix_es_catalog_like
branch
from
b20d14d to
97e5c2f
Compare
Contributor
Author
|
run buildall |
We map `text` and `keyword` both to `string` type in Doris. When enable `like_push_down`, we translate like to wildcard query in ES, which will lead unexpected result in `text` field. We should stick to `keyword` with wildcard query. 1. Add `column2typeMap` in `EsTable` to save the mapping of column_name to ES field data type. 2. Add new class `EsSchemaCacheValue` to get schema and column to type map 2. Init `column2typeMap` when cache init and build query process of ES external table
2. Add end to end test case for like.
qidaye
force-pushed
the
fix_es_catalog_like
branch
from
97e5c2f to
e7dc509
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
#41176) ## Proposed changes We map `text` and `keyword` both to `string` type in Doris. When enable `like_push_down`, we translate like to wildcard query in ES, which will lead unexpected result in `text` field. We should stick to `keyword` with wildcard query. 1. Add `column2typeMap` in `EsTable` to save the mapping of column_name to ES field data type. 2. Add new class `EsSchemaCacheValue` to get schema and column to type map 3. Init `column2typeMap` when cache init and build query process of ES external table 4. Support LIKE functionCallExpr for Nereids planner. 5. Add end to end like predicate test cases and UTs
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
#41176) ## Proposed changes We map `text` and `keyword` both to `string` type in Doris. When enable `like_push_down`, we translate like to wildcard query in ES, which will lead unexpected result in `text` field. We should stick to `keyword` with wildcard query. 1. Add `column2typeMap` in `EsTable` to save the mapping of column_name to ES field data type. 2. Add new class `EsSchemaCacheValue` to get schema and column to type map 3. Init `column2typeMap` when cache init and build query process of ES external table 4. Support LIKE functionCallExpr for Nereids planner. 5. Add end to end like predicate test cases and UTs
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Nov 7, 2024
apache#41176) We map `text` and `keyword` both to `string` type in Doris. When enable `like_push_down`, we translate like to wildcard query in ES, which will lead unexpected result in `text` field. We should stick to `keyword` with wildcard query. 1. Add `column2typeMap` in `EsTable` to save the mapping of column_name to ES field data type. 2. Add new class `EsSchemaCacheValue` to get schema and column to type map 3. Init `column2typeMap` when cache init and build query process of ES external table 4. Support LIKE functionCallExpr for Nereids planner. 5. Add end to end like predicate test cases and UTs
airborne12
pushed a commit
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We map
textandkeywordboth tostringtype in Doris. When enablelike_push_down, we translate like to wildcard query in ES, which will lead unexpected result intextfield. We should stick tokeywordwith wildcard query.column2typeMapinEsTableto save the mapping of column_name to ES field data type.EsSchemaCacheValueto get schema and column to type mapcolumn2typeMapwhen cache init and build query process of ES external table