Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Sep 24, 2024

revert #35644

table if not set storage medium, will set default by Config.default_storage_medium,
at present, we cannot distinguish whether the storage medium of the table is set by the user.
If it is not set by the user, it represents priority use rather than mandatory use. If we directly inherit the storage medium of the table, it may cause the partition to be forced to use 'Config. default_storage_madium', resulting in the partition being unable to be created

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr
Copy link
Contributor Author

zddr commented Sep 24, 2024

run buildall

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow changed the title [revert](mtmv)storage medium of partition can not extend from table [revert](storage) storage medium of partition should not inherit from table Sep 24, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit b0449d2 into apache:master Sep 24, 2024
zddr added a commit to zddr/incubator-doris that referenced this pull request Sep 24, 2024
… table (apache#41192)

revert apache#35644

table if not set storage medium, will set default by
`Config.default_storage_medium`,
at present, we cannot distinguish whether the storage medium of the
table is set by the user.
If it is not set by the user, it represents priority use rather than
mandatory use. If we directly inherit the storage medium of the table,
it may cause the partition to be forced to use 'Config.
default_storage_madium', resulting in the partition being unable to be
created
zddr added a commit to zddr/incubator-doris that referenced this pull request Sep 24, 2024
… table (apache#41192)

revert apache#35644

table if not set storage medium, will set default by
`Config.default_storage_medium`,
at present, we cannot distinguish whether the storage medium of the
table is set by the user.
If it is not set by the user, it represents priority use rather than
mandatory use. If we directly inherit the storage medium of the table,
it may cause the partition to be forced to use 'Config.
default_storage_madium', resulting in the partition being unable to be
created
dataroaring pushed a commit that referenced this pull request Sep 26, 2024
… table (#41192)

revert #35644

table if not set storage medium, will set default by
`Config.default_storage_medium`,
at present, we cannot distinguish whether the storage medium of the
table is set by the user.
If it is not set by the user, it represents priority use rather than
mandatory use. If we directly inherit the storage medium of the table,
it may cause the partition to be forced to use 'Config.
default_storage_madium', resulting in the partition being unable to be
created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants