Skip to content

[opt](function)Optimize the Percentile function. #41206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 3 commits into from
Sep 27, 2024
Merged

[opt](function)Optimize the Percentile function. #41206

zhangstar333 merged 3 commits into from
Sep 27, 2024

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Sep 24, 2024 •
edited
Loading

Proposed changes

Support batch functions and floating-point parameters.

@doris-robot
Copy link

doris-robot commented Sep 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Sep 24, 2024

run buildall

@Mryange Mryange changed the title [opt](function) [opt](function)Optimize the Percentile function. Sep 24, 2024
@Mryange
Copy link
Contributor Author

Mryange commented Sep 24, 2024

run buildall

@Mryange Mryange marked this pull request as ready for review September 24, 2024 09:39
@doris-robot
Copy link

doris-robot commented Sep 24, 2024

TeamCity be ut coverage result:
Function Coverage: 37.29% (9618/25791)
Line Coverage: 28.71% (79603/277277)
Region Coverage: 28.16% (41168/146202)
Branch Coverage: 24.78% (20973/84624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e18a82479891174c20c59920e16d3244bea59315_e18a82479891174c20c59920e16d3244bea59315/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Sep 24, 2024

run cloud_p0

@Mryange
Copy link
Contributor Author

Mryange commented Sep 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 25, 2024

TeamCity be ut coverage result:
Function Coverage: 37.31% (9623/25794)
Line Coverage: 28.71% (79623/277348)
Region Coverage: 28.16% (41184/146251)
Branch Coverage: 24.79% (20982/84654)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8de5d3150fe92bb575fa874507c56cd6e804c36a_8de5d3150fe92bb575fa874507c56cd6e804c36a/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Sep 25, 2024

run buildall

HappenLee
HappenLee approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 25, 2024

TeamCity be ut coverage result:
Function Coverage: 37.31% (9623/25790)
Line Coverage: 28.73% (79663/277310)
Region Coverage: 28.16% (41187/146258)
Branch Coverage: 24.79% (20990/84658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8de5d3150fe92bb575fa874507c56cd6e804c36a_8de5d3150fe92bb575fa874507c56cd6e804c36a/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Sep 25, 2024

run p0

@Mryange
Copy link
Contributor Author

Mryange commented Sep 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 25, 2024

TeamCity be ut coverage result:
Function Coverage: 37.29% (9625/25812)
Line Coverage: 28.71% (79671/277517)
Region Coverage: 28.12% (41178/146440)
Branch Coverage: 24.76% (20983/84738)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a590e6e7d7d8834e88dcbf0755f39ab4aa1be61a_a590e6e7d7d8834e88dcbf0755f39ab4aa1be61a/report/index.html

@zhangstar333 zhangstar333 merged commit ac7084c into apache:master Sep 27, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@Mryange @dataroaring
[opt](function)Optimize the Percentile function. (#41206)
3c44ca9 
## Proposed changes
Support batch functions and floating-point parameters.

<!--Describe your changes.-->
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@Mryange @cjj2010
[opt](function)Optimize the Percentile function. (apache#41206)
bed3beb 
## Proposed changes
Support batch functions and floating-point parameters.

<!--Describe your changes.-->
@zhangstar333 zhangstar333 mentioned this pull request Nov 14, 2024
Merged
16 tasks
zhangstar333 added a commit that referenced this pull request Nov 18, 2024
@zhangstar333
[optimization](agg) add float/double type in agg percentile_array (#4…
d22b5b8 
…3953)

### What problem does this PR solve?
Related PR: #41206
Problem Summary:
before in pr #41206 have support float/double in percentile function, 
and percentile_array is the same logical, so it's could support
float/double also.

doc: apache/doris-website#1350
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Feb 19, 2025
@zhangstar333
[optimization](agg) add float/double type in agg percentile_array (ap…
5c21935 
…ache#43953)

Related PR: apache#41206
Problem Summary:
before in pr apache#41206 have support float/double in percentile function,
and percentile_array is the same logical, so it's could support
float/double also.

doc: apache/doris-website#1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

+1 more reviewer

@superdiaodiao superdiaodiao superdiaodiao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mryange @doris-robot @HappenLee @superdiaodiao @zhangstar333 @dataroaring