Skip to content

[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json #41217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 4 commits into from
Oct 11, 2024
Merged

[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json #41217

morningman merged 4 commits into from
Oct 11, 2024

Conversation

@hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Sep 24, 2024

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Sep 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hubgeter
Copy link
Contributor Author

hubgeter commented Sep 24, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 24, 2024

TPC-H: Total hot run time: 41268 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb7d7e90c953efa7872f960f0df083a82d604466, data reload: false

------ Round 1 ----------------------------------
q1	17777	7437	8070	7437
q2	2022	303	287	287
q3	12286	1038	1222	1038
q4	10560	757	700	700
q5	7773	2937	2866	2866
q6	237	154	151	151
q7	992	627	607	607
q8	9363	1946	1917	1917
q9	6573	6493	6850	6493
q10	6994	2312	2309	2309
q11	435	236	245	236
q12	410	217	212	212
q13	17776	2954	2999	2954
q14	246	217	218	217
q15	587	529	517	517
q16	687	618	601	601
q17	974	617	545	545
q18	7236	6748	6608	6608
q19	1397	1072	1053	1053
q20	598	287	286	286
q21	4302	3332	3237	3237
q22	1081	1008	997	997
Total cold run time: 110306 ms
Total hot run time: 41268 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7261	7209	7252	7209
q2	359	244	244	244
q3	3079	2990	2875	2875
q4	2107	1874	1783	1783
q5	5772	5669	5828	5669
q6	233	143	142	142
q7	2193	1796	1793	1793
q8	3353	3568	3565	3565
q9	8992	8987	8935	8935
q10	3549	3577	3629	3577
q11	589	480	492	480
q12	824	623	613	613
q13	9233	3131	3189	3131
q14	325	275	290	275
q15	566	532	522	522
q16	719	672	656	656
q17	1860	1651	1606	1606
q18	8243	7983	7928	7928
q19	1697	1490	1620	1490
q20	2121	1880	1919	1880
q21	5639	5423	5402	5402
q22	1150	1041	1041	1041
Total cold run time: 69864 ms
Total hot run time: 60816 ms

@doris-robot
Copy link

doris-robot commented Sep 24, 2024

TeamCity be ut coverage result:
Function Coverage: 37.30% (9618/25787)
Line Coverage: 28.71% (79604/277299)
Region Coverage: 28.14% (41158/146237)
Branch Coverage: 24.78% (20976/84650)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bb7d7e90c953efa7872f960f0df083a82d604466_bb7d7e90c953efa7872f960f0df083a82d604466/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 24, 2024

TPC-DS: Total hot run time: 192722 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb7d7e90c953efa7872f960f0df083a82d604466, data reload: false

query1	940	381	419	381
query2	6390	2081	2083	2081
query3	8685	196	207	196
query4	33872	23661	23585	23585
query5	3392	483	470	470
query6	260	164	159	159
query7	4189	305	312	305
query8	301	226	225	225
query9	9664	2676	2679	2676
query10	485	276	288	276
query11	18103	15319	15287	15287
query12	154	102	99	99
query13	1532	434	416	416
query14	9463	7043	6957	6957
query15	252	167	184	167
query16	8034	466	496	466
query17	1636	618	629	618
query18	2126	329	325	325
query19	254	167	153	153
query20	121	119	118	118
query21	217	107	107	107
query22	4878	4791	4526	4526
query23	35430	34858	34823	34823
query24	11031	2885	2936	2885
query25	633	424	419	419
query26	1168	162	162	162
query27	2338	299	299	299
query28	7833	2459	2427	2427
query29	850	453	441	441
query30	256	157	156	156
query31	1050	771	787	771
query32	96	57	56	56
query33	753	304	296	296
query34	923	510	489	489
query35	887	733	736	733
query36	1115	940	955	940
query37	152	91	86	86
query38	4132	3977	3894	3894
query39	1508	1420	1402	1402
query40	206	99	98	98
query41	52	49	50	49
query42	118	95	94	94
query43	537	486	479	479
query44	1195	805	793	793
query45	195	169	170	169
query46	1143	712	700	700
query47	1956	1821	1864	1821
query48	478	371	374	371
query49	922	421	393	393
query50	831	413	405	405
query51	7060	7027	6889	6889
query52	100	85	86	85
query53	251	180	183	180
query54	1156	468	462	462
query55	81	77	77	77
query56	282	256	266	256
query57	1246	1107	1094	1094
query58	230	239	231	231
query59	3114	3140	2871	2871
query60	302	280	278	278
query61	105	116	102	102
query62	837	676	654	654
query63	214	194	180	180
query64	3956	649	611	611
query65	3265	3231	3200	3200
query66	764	298	313	298
query67	15943	15629	15652	15629
query68	4574	559	551	551
query69	548	293	286	286
query70	1179	1133	1112	1112
query71	402	267	276	267
query72	7623	3977	4026	3977
query73	769	341	349	341
query74	10381	9006	8942	8942
query75	3715	2661	2703	2661
query76	3740	920	914	914
query77	643	298	298	298
query78	10161	10144	9493	9493
query79	2345	597	602	597
query80	1627	444	443	443
query81	597	244	244	244
query82	671	141	141	141
query83	309	139	133	133
query84	284	77	87	77
query85	880	298	274	274
query86	467	310	291	291
query87	4483	4311	4386	4311
query88	3790	2416	2378	2378
query89	404	296	294	294
query90	1880	186	186	186
query91	188	143	141	141
query92	59	48	48	48
query93	2184	534	545	534
query94	968	303	289	289
query95	355	255	256	255
query96	629	282	281	281
query97	3228	3124	3190	3124
query98	223	196	190	190
query99	1525	1309	1308	1308
Total cold run time: 302473 ms
Total hot run time: 192722 ms

@doris-robot
Copy link

doris-robot commented Sep 24, 2024

ClickBench: Total hot run time: 33.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb7d7e90c953efa7872f960f0df083a82d604466, data reload: false

query1	0.04	0.05	0.04
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.65	0.11	0.10
query5	0.52	0.52	0.50
query6	1.12	0.73	0.72
query7	0.01	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.49
query10	0.55	0.56	0.54
query11	0.14	0.12	0.11
query12	0.13	0.11	0.12
query13	0.63	0.60	0.59
query14	3.10	2.96	2.93
query15	0.90	0.83	0.82
query16	0.38	0.38	0.38
query17	1.05	1.03	1.01
query18	0.20	0.20	0.20
query19	1.84	1.88	2.02
query20	0.01	0.01	0.02
query21	15.36	0.60	0.57
query22	3.16	2.88	2.41
query23	17.14	0.95	0.78
query24	2.58	1.46	1.11
query25	0.31	0.16	0.05
query26	0.30	0.13	0.13
query27	0.03	0.04	0.04
query28	10.49	1.10	1.06
query29	12.52	3.20	3.21
query30	0.24	0.06	0.05
query31	2.90	0.39	0.38
query32	3.25	0.47	0.46
query33	3.00	3.02	3.04
query34	16.89	4.40	4.54
query35	4.48	4.52	4.53
query36	0.68	0.47	0.47
query37	0.08	0.05	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.95 s
Total hot run time: 33.51 s

@hubgeter hubgeter force-pushed the fix_opt_fill_partition branch from 98c69e0 to 65f9290 Compare October 8, 2024 10:46
@hubgeter
Copy link
Contributor Author

hubgeter commented Oct 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2024

TPC-H: Total hot run time: 41028 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 65f9290cdb7a82d03c7721b3d3f72f019486b2f0, data reload: false

------ Round 1 ----------------------------------
q1	17915	7650	7476	7476
q2	2247	161	160	160
q3	11603	1134	1244	1134
q4	10687	780	770	770
q5	8096	2942	2895	2895
q6	244	150	159	150
q7	1037	650	626	626
q8	9651	1963	1978	1963
q9	6587	6414	6398	6398
q10	6972	2287	2387	2287
q11	454	264	259	259
q12	407	224	224	224
q13	17782	3009	2983	2983
q14	256	209	221	209
q15	574	526	509	509
q16	638	605	588	588
q17	1002	570	578	570
q18	7278	6586	6592	6586
q19	1345	990	954	954
q20	531	196	197	196
q21	3952	3340	3107	3107
q22	1121	999	984	984
Total cold run time: 110379 ms
Total hot run time: 41028 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7256	7261	7267	7261
q2	338	230	227	227
q3	2894	2733	2822	2733
q4	1956	1730	1695	1695
q5	5466	5476	5489	5476
q6	223	137	138	137
q7	2165	1729	1719	1719
q8	3221	3415	3438	3415
q9	8577	8546	8584	8546
q10	3487	3471	3440	3440
q11	592	482	470	470
q12	793	559	580	559
q13	5838	3017	3004	3004
q14	290	272	258	258
q15	567	510	508	508
q16	691	648	642	642
q17	1814	1597	1572	1572
q18	7726	7532	7522	7522
q19	1665	1516	1345	1345
q20	2023	1792	1816	1792
q21	5378	5297	5202	5202
q22	1088	1006	984	984
Total cold run time: 64048 ms
Total hot run time: 58507 ms

@doris-robot
Copy link

doris-robot commented Oct 8, 2024

TPC-DS: Total hot run time: 191366 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 65f9290cdb7a82d03c7721b3d3f72f019486b2f0, data reload: false

query1	963	369	367	367
query2	6523	2112	2081	2081
query3	6697	210	221	210
query4	33782	23561	23434	23434
query5	4293	465	463	463
query6	276	178	168	168
query7	4650	316	311	311
query8	295	231	224	224
query9	9726	2698	2687	2687
query10	481	286	289	286
query11	18016	15205	15232	15205
query12	152	99	99	99
query13	1691	485	455	455
query14	10351	7465	7048	7048
query15	269	173	186	173
query16	8050	478	463	463
query17	1678	580	554	554
query18	2150	322	317	317
query19	367	151	150	150
query20	121	105	110	105
query21	214	108	106	106
query22	4479	4310	4274	4274
query23	34792	34095	34058	34058
query24	10791	2890	2834	2834
query25	619	420	404	404
query26	723	165	170	165
query27	2078	302	301	301
query28	6696	2426	2401	2401
query29	759	436	432	432
query30	325	160	159	159
query31	1053	795	837	795
query32	100	57	58	57
query33	689	318	297	297
query34	897	523	522	522
query35	878	735	747	735
query36	1116	944	930	930
query37	142	97	86	86
query38	4022	4002	3967	3967
query39	1479	1478	1404	1404
query40	205	99	98	98
query41	52	46	47	46
query42	119	99	99	99
query43	551	506	492	492
query44	1152	820	819	819
query45	200	170	169	169
query46	1139	705	705	705
query47	1934	1817	1860	1817
query48	429	345	344	344
query49	1123	409	413	409
query50	821	421	418	418
query51	7173	6960	6842	6842
query52	97	87	90	87
query53	282	192	185	185
query54	1115	483	482	482
query55	80	78	78	78
query56	282	266	296	266
query57	1228	1138	1147	1138
query58	235	237	232	232
query59	3265	2962	2972	2962
query60	296	265	261	261
query61	108	103	102	102
query62	865	669	645	645
query63	232	189	193	189
query64	3798	640	620	620
query65	3263	3182	3191	3182
query66	889	316	308	308
query67	15811	15438	15353	15353
query68	4619	571	558	558
query69	461	300	288	288
query70	1187	1144	1087	1087
query71	366	268	271	268
query72	6463	4021	3898	3898
query73	773	352	347	347
query74	10108	8975	9090	8975
query75	3419	2658	2636	2636
query76	2845	869	963	869
query77	462	294	276	276
query78	10408	9535	9505	9505
query79	2753	605	633	605
query80	1261	455	443	443
query81	596	245	245	245
query82	901	137	133	133
query83	229	136	149	136
query84	262	85	76	76
query85	1186	286	298	286
query86	446	292	308	292
query87	4442	4433	4310	4310
query88	4130	2452	2429	2429
query89	403	288	294	288
query90	1818	196	201	196
query91	150	107	105	105
query92	63	49	48	48
query93	2037	548	554	548
query94	892	293	287	287
query95	352	257	261	257
query96	634	284	288	284
query97	3277	3129	3179	3129
query98	223	209	192	192
query99	1719	1295	1311	1295
Total cold run time: 298012 ms
Total hot run time: 191366 ms

@doris-robot
Copy link

doris-robot commented Oct 8, 2024

ClickBench: Total hot run time: 32.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 65f9290cdb7a82d03c7721b3d3f72f019486b2f0, data reload: false

query1	0.05	0.05	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.10
query5	0.53	0.54	0.51
query6	1.13	0.74	0.72
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.52
query10	0.55	0.53	0.55
query11	0.14	0.10	0.10
query12	0.13	0.11	0.10
query13	0.61	0.60	0.59
query14	2.84	2.76	2.81
query15	0.90	0.83	0.83
query16	0.38	0.37	0.38
query17	1.03	1.06	1.06
query18	0.23	0.23	0.22
query19	1.87	1.83	1.98
query20	0.01	0.01	0.02
query21	15.38	0.58	0.58
query22	3.13	2.07	1.50
query23	16.93	0.94	0.86
query24	2.69	1.18	1.19
query25	0.21	0.16	0.06
query26	0.50	0.13	0.13
query27	0.04	0.04	0.04
query28	10.67	1.08	1.08
query29	12.58	3.23	3.29
query30	0.24	0.06	0.06
query31	2.89	0.38	0.38
query32	3.28	0.46	0.46
query33	3.00	2.98	3.05
query34	17.15	4.44	4.50
query35	4.48	4.52	4.47
query36	0.65	0.48	0.50
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 107.25 s
Total hot run time: 32.63 s

@doris-robot
Copy link

doris-robot commented Oct 8, 2024

TeamCity be ut coverage result:
Function Coverage: 37.28% (9631/25832)
Line Coverage: 28.66% (79862/278619)
Region Coverage: 28.11% (41310/146968)
Branch Coverage: 24.73% (21044/85112)
Coverage Report: http://coverage.selectdb-in.cc/coverage/65f9290cdb7a82d03c7721b3d3f72f019486b2f0_65f9290cdb7a82d03c7721b3d3f72f019486b2f0/report/index.html

morningman
morningman approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman force-pushed the fix_opt_fill_partition branch from 65f9290 to 04d7fe4 Compare October 9, 2024 11:05
@morningman
Copy link
Contributor

morningman commented Oct 9, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 9, 2024

TPC-H: Total hot run time: 40631 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 04d7fe40684d45f8ff3d6caa4b79a042f405dcf6, data reload: false

------ Round 1 ----------------------------------
q1	17772	7449	7226	7226
q2	2045	277	289	277
q3	12211	1076	1175	1076
q4	10578	769	766	766
q5	7769	2867	2802	2802
q6	242	156	147	147
q7	1004	664	612	612
q8	9374	1955	1944	1944
q9	6547	6426	6463	6426
q10	6994	2285	2319	2285
q11	449	245	251	245
q12	404	213	216	213
q13	17784	2970	2972	2970
q14	244	218	213	213
q15	558	531	510	510
q16	655	588	583	583
q17	985	537	636	537
q18	7399	6640	6604	6604
q19	1507	927	948	927
q20	495	209	197	197
q21	3956	3099	3123	3099
q22	1084	972	982	972
Total cold run time: 110056 ms
Total hot run time: 40631 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7186	7191	7167	7167
q2	336	227	235	227
q3	2985	2894	2947	2894
q4	2046	1831	1784	1784
q5	5786	5740	5719	5719
q6	225	140	140	140
q7	2243	1799	1844	1799
q8	3372	3580	3520	3520
q9	8926	8944	8867	8867
q10	3584	3576	3529	3529
q11	582	492	499	492
q12	812	665	641	641
q13	10205	3139	3132	3132
q14	296	272	268	268
q15	593	506	520	506
q16	703	645	645	645
q17	1866	1615	1599	1599
q18	8323	7713	7771	7713
q19	1709	1354	1544	1354
q20	2113	1859	1894	1859
q21	5563	5346	5545	5346
q22	1163	1020	1040	1020
Total cold run time: 70617 ms
Total hot run time: 60221 ms

@doris-robot
Copy link

doris-robot commented Oct 9, 2024

TPC-DS: Total hot run time: 191673 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 04d7fe40684d45f8ff3d6caa4b79a042f405dcf6, data reload: false

query1	942	407	424	407
query2	6234	2104	1960	1960
query3	8679	196	208	196
query4	33900	23447	23452	23447
query5	3508	481	462	462
query6	261	168	158	158
query7	4182	300	306	300
query8	279	216	229	216
query9	9130	2674	2672	2672
query10	465	276	294	276
query11	17860	15288	15105	15105
query12	143	98	98	98
query13	1570	461	457	457
query14	9363	7447	7567	7447
query15	274	172	181	172
query16	7823	453	481	453
query17	1629	605	595	595
query18	1972	336	315	315
query19	270	161	156	156
query20	121	117	118	117
query21	218	110	109	109
query22	4731	4604	4707	4604
query23	35268	33903	33953	33903
query24	11003	2885	2830	2830
query25	591	414	408	408
query26	862	158	161	158
query27	2129	298	306	298
query28	6370	2461	2433	2433
query29	770	427	427	427
query30	307	149	153	149
query31	1053	809	773	773
query32	98	52	54	52
query33	765	300	303	300
query34	912	514	513	513
query35	870	751	729	729
query36	1103	962	981	962
query37	153	83	82	82
query38	3971	3957	4032	3957
query39	1472	1431	1411	1411
query40	206	97	95	95
query41	47	43	43	43
query42	117	96	101	96
query43	523	479	490	479
query44	1298	800	800	800
query45	194	168	169	168
query46	1153	704	715	704
query47	1906	1797	1859	1797
query48	435	363	332	332
query49	998	412	393	393
query50	814	423	407	407
query51	7115	6986	6980	6980
query52	97	85	90	85
query53	257	187	179	179
query54	1227	470	473	470
query55	80	77	85	77
query56	282	266	275	266
query57	1255	1142	1153	1142
query58	225	242	240	240
query59	3232	3171	2905	2905
query60	298	272	271	271
query61	105	101	101	101
query62	894	674	679	674
query63	215	187	184	184
query64	3844	637	627	627
query65	3259	3131	3207	3131
query66	838	311	311	311
query67	15930	15462	15410	15410
query68	4414	575	590	575
query69	486	290	326	290
query70	1205	1152	1136	1136
query71	354	280	270	270
query72	6643	3942	3952	3942
query73	760	340	351	340
query74	10289	8994	9107	8994
query75	3445	2714	2640	2640
query76	2779	909	915	909
query77	624	300	296	296
query78	10447	9600	9492	9492
query79	1269	591	593	591
query80	823	445	464	445
query81	549	238	246	238
query82	737	147	136	136
query83	284	138	133	133
query84	274	76	75	75
query85	1044	313	281	281
query86	321	311	301	301
query87	4367	4193	4378	4193
query88	3139	2411	2386	2386
query89	414	287	289	287
query90	2097	188	182	182
query91	138	105	104	104
query92	60	48	47	47
query93	1053	534	540	534
query94	874	289	296	289
query95	351	247	245	245
query96	607	283	285	283
query97	3214	3089	3136	3089
query98	210	209	195	195
query99	1772	1296	1281	1281
Total cold run time: 293138 ms
Total hot run time: 191673 ms

@doris-robot
Copy link

doris-robot commented Oct 9, 2024

TeamCity be ut coverage result:
Function Coverage: 37.29% (9636/25839)
Line Coverage: 28.68% (79919/278641)
Region Coverage: 28.09% (41316/147103)
Branch Coverage: 24.70% (21035/85160)
Coverage Report: http://coverage.selectdb-in.cc/coverage/04d7fe40684d45f8ff3d6caa4b79a042f405dcf6_04d7fe40684d45f8ff3d6caa4b79a042f405dcf6/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 9, 2024

ClickBench: Total hot run time: 32.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 04d7fe40684d45f8ff3d6caa4b79a042f405dcf6, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.04
query3	0.23	0.06	0.07
query4	1.64	0.11	0.10
query5	0.51	0.49	0.51
query6	1.12	0.75	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.56	0.51	0.50
query10	0.58	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.61	0.61	0.61
query14	2.85	2.77	2.75
query15	0.89	0.82	0.82
query16	0.39	0.37	0.40
query17	1.04	1.02	1.03
query18	0.20	0.20	0.20
query19	1.90	1.81	2.02
query20	0.02	0.01	0.00
query21	15.36	0.58	0.58
query22	2.64	2.11	1.78
query23	17.00	0.88	0.72
query24	2.94	1.01	0.91
query25	0.20	0.15	0.05
query26	0.47	0.14	0.14
query27	0.04	0.04	0.03
query28	10.90	1.07	1.07
query29	12.57	3.33	3.28
query30	0.25	0.05	0.06
query31	2.89	0.39	0.38
query32	3.28	0.46	0.46
query33	2.99	3.01	2.98
query34	17.00	4.42	4.45
query35	4.49	4.48	4.47
query36	0.67	0.49	0.49
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.03
query40	0.16	0.14	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.1 s
Total hot run time: 32.41 s

morningman
morningman approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR approved by anyone and no changes requested.

@suxiaogang223
Copy link
Contributor

suxiaogang223 commented Oct 11, 2024

+1

@morningman morningman changed the title [fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json2 [fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json Oct 11, 2024
@morningman morningman merged commit ce595c2 into apache:master Oct 11, 2024
hubgeter added a commit to hubgeter/doris that referenced this pull request Oct 16, 2024
@hubgeter
[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_f…
1e33237 
…rom_fixed_json (apache#41217)
@hubgeter hubgeter mentioned this pull request Oct 16, 2024
Merged
hubgeter added a commit to hubgeter/doris that referenced this pull request Oct 16, 2024
@hubgeter
[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_f…
9f6a919 
…rom_fixed_json (apache#41217)
@hubgeter hubgeter mentioned this pull request Oct 16, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 17, 2024
@hubgeter
[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_f…
0b41cd2 
…rom_fixed_json (#41217) (#41960)

bp #41217 

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
morningman pushed a commit that referenced this pull request Oct 17, 2024
@hubgeter
[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_f…
bf0250a 
…rom_fixed_json (#41217) (#41963)

bp #41217
@gavinchou gavinchou added the cir label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@suxiaogang223 suxiaogang223 suxiaogang223 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cir dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hubgeter @doris-robot @morningman @suxiaogang223 @gavinchou @yiguolei