[fix](new_json_reader)fix new_json_reader core #41290

amorynan · 2024-09-25T10:03:16Z

Proposed changes

if we put not json object or json array in json file with select tvf , here will meet core like :

SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]
[WARNING!] /sys/kernel/mm/transparent_hugepage/enabled: [always] madvise never, Doris not recommend turning on THP, which may cause the BE process to use more memory and cannot be freed in time. Turn off THP: `echo madvise | sudo tee /sys/kernel/mm/transparent_hugepage/enabled`
start BE in local mode
doris_be: /mnt/disk1/wangqiannan/amory/doris/thirdparty/installed/include/rapidjson/document.h:1178：SizeType rapidjson::GenericValue<rapidjson::UTF8<>>::MemberCount() const [Encoding = rapidjson::UTF8<>, Allocator = rapidjson::MemoryPoolAllocator<>]: 假设 ‘IsObject()’ 失
败。
*** Query id: 0-0 ***
*** is nereids: 0 ***
*** tablet id: 0 ***
*** Aborted at 1727253403 (unix time) try "date -d @1727253403" if you are using GNU date ***
*** Current BE git commitID: daf0fa72c5 ***
*** SIGABRT unknown detail explain (@0x461000ac22f) received by PID 705071 (TID 711574 OR 0x7f35fb40a700) from PID 705071; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk1/wangqiannan/amory/doris/be/src/common/signal_handler.h:421
 1# 0x00007F3A3902EB50 in /lib64/libc.so.6
 2# gsignal in /lib64/libc.so.6
 3# __GI_abort in /lib64/libc.so.6
 4# _nl_load_domain.cold.0 in /lib64/libc.so.6
 5# 0x00007F3A39027426 in /lib64/libc.so.6
 6# rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator> >::MemberCount() const at /mnt/disk1/wangqiannan/amory/doris/thirdparty/installed/include/rapidjson/document.h:1178
 7# doris::vectorized::NewJsonReader::get_parsed_schema(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >*, std::vector<doris::TypeDescriptor, std::allocator<doris::TypeDescriptor> >*) at /mnt/disk1/wangqiannan/amory/doris/be/src/vec/exec/format/json/new_json_reader.cpp:347
 8# doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0::operator()() const at /mnt/disk1/wangqiannan/amory/doris/be/src/service/internal_service.cpp:832
 9# void std::__invoke_impl<void, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&>(std::__invoke_other, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61
10# std::enable_if<is_invocable_r_v<void, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&>, void>::type std::__invoke_r<void, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&>(doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:117
11# std::_Function_handler<void (), doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
12# std::function<void ()>::operator()() const at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560
13# doris::WorkThreadPool<false>::work_thread(int) at /mnt/disk1/wangqiannan/amory/doris/be/src/util/work_thread_pool.hpp:158
14# void std::__invoke_impl<void, void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&>(std::__invoke_memfun_deref, void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:74
15# std::__invoke_result<void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&>::type std::__invoke<void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&>(void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96
16# decltype (std::__invoke((*this)._M_pmf, std::forward<doris::WorkThreadPool<false>*&>({parm#1}), std::forward<int&>({parm#1}))) std::_Mem_fn_base<void (doris::WorkThreadPool<false>::*)(int), true>::operator()<doris::WorkThreadPool<false>*&, int&>(doris::WorkThreadPool<false>*&, int&) const at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:131
17# void std::__invoke_impl<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&>(std::__invoke_other, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61
18# std::enable_if<is_invocable_r_v<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&>, void>::type std::__invoke_r<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&>(std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:117
19# void std::_Bind_result<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)> (doris::WorkThreadPool<false>*, int)>::__call<void, , 0ul, 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:570

Issue Number: close #xxx

doris-robot · 2024-09-25T10:03:21Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

eldenmoon

LGTM

github-actions · 2024-09-26T01:56:36Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-26T01:56:38Z

PR approved by anyone and no changes requested.

amorynan · 2024-09-26T12:16:46Z

run buildall

doris-robot · 2024-09-26T12:41:29Z

TeamCity be ut coverage result:
Function Coverage: 37.31% (9635/25823)
Line Coverage: 28.72% (79756/277656)
Region Coverage: 28.14% (41228/146507)
Branch Coverage: 24.76% (20991/84766)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b6fd419f271b2b9a7d38712b124e41d30f20c804_b6fd419f271b2b9a7d38712b124e41d30f20c804/report/index.html

xiaokang · 2024-09-26T23:55:51Z

be/src/vec/exec/format/json/new_json_reader.cpp

    }

+    if (!objectValue->IsObject()) {
+        return Status::DataQualityError("JSON data is not an object.");


add first n bytes of data in error message

Does this issue only occur in the TVF?

Yes , only in select tvf . streamload will return false

What do you mean by streamload will return false? I'm concerned that this change might affect other load.

this function just for scanner to read json file when in tvf , other load will not call this function
just with VFileScanner::_get_block_wrapped --> NewJsonReader::get_next_block --> NewJsonReader::_read_json_column --> NewJsonReader::_vhandle_simple_json --> NewJsonReader::_set_column_value

and I think I could print origin type instead of n bytes...

amorynan · 2024-10-12T09:08:51Z

run buildall

github-actions · 2024-10-12T09:13:05Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-10-12T09:35:23Z

TeamCity be ut coverage result:
Function Coverage: 37.43% (9679/25862)
Line Coverage: 28.68% (80277/279925)
Region Coverage: 28.11% (41513/147685)
Branch Coverage: 24.70% (21109/85464)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7ab2f15f3bfe2334ee722b056c1950f4bf72456e_7ab2f15f3bfe2334ee722b056c1950f4bf72456e/report/index.html

amorynan · 2024-11-01T08:06:45Z

run buildall

github-actions · 2024-11-01T08:10:36Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-11-01T08:32:35Z

TeamCity be ut coverage result:
Function Coverage: 37.82% (9821/25971)
Line Coverage: 29.00% (81633/281540)
Region Coverage: 28.27% (42157/149124)
Branch Coverage: 24.85% (21394/86076)
Coverage Report: http://coverage.selectdb-in.cc/coverage/01a601be04b00903bb6a860536b6364344e89186_01a601be04b00903bb6a860536b6364344e89186/report/index.html

amorynan · 2024-11-01T09:18:14Z

run cloud_p0

eldenmoon

LGTM

github-actions · 2024-11-01T09:55:01Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-03T07:41:29Z

clang-tidy review says "All clean, LGTM! 👍"

amorynan · 2024-11-03T11:00:36Z

run buildall

github-actions · 2024-11-03T11:04:55Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-11-03T11:39:20Z

TeamCity be ut coverage result:
Function Coverage: 37.82% (9821/25967)
Line Coverage: 28.98% (81597/281567)
Region Coverage: 28.26% (42147/149155)
Branch Coverage: 24.84% (21386/86108)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9a95c48857dcc2b12443b116d7d047b6dbb6187c_9a95c48857dcc2b12443b116d7d047b6dbb6187c/report/index.html

xiaokang

LGTM

github-actions · 2024-11-03T23:18:45Z

PR approved by at least one committer and no changes requested.

eldenmoon

LGTM

if we put not json object or json array in json file with select tvf , here will meet core like : ``` SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory] [WARNING!] /sys/kernel/mm/transparent_hugepage/enabled: [always] madvise never, Doris not recommend turning on THP, which may cause the BE process to use more memory and cannot be freed in time. Turn off THP: `echo madvise | sudo tee /sys/kernel/mm/transparent_hugepage/enabled` start BE in local mode doris_be: /mnt/disk1/wangqiannan/amory/doris/thirdparty/installed/include/rapidjson/document.h:1178：SizeType rapidjson::GenericValue<rapidjson::UTF8<>>::MemberCount() const [Encoding = rapidjson::UTF8<>, Allocator = rapidjson::MemoryPoolAllocator<>]: 假设 ‘IsObject()’ 失败。 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1727253403 (unix time) try "date -d @1727253403" if you are using GNU date *** *** Current BE git commitID: daf0fa7 *** *** SIGABRT unknown detail explain (@0x461000ac22f) received by PID 705071 (TID 711574 OR 0x7f35fb40a700) from PID 705071; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk1/wangqiannan/amory/doris/be/src/common/signal_handler.h:421 1# 0x00007F3A3902EB50 in /lib64/libc.so.6 2# gsignal in /lib64/libc.so.6 3# __GI_abort in /lib64/libc.so.6 4# _nl_load_domain.cold.0 in /lib64/libc.so.6 5# 0x00007F3A39027426 in /lib64/libc.so.6 6# rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator> >::MemberCount() const at /mnt/disk1/wangqiannan/amory/doris/thirdparty/installed/include/rapidjson/document.h:1178 7# doris::vectorized::NewJsonReader::get_parsed_schema(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >*, std::vector<doris::TypeDescriptor, std::allocator<doris::TypeDescriptor> >*) at /mnt/disk1/wangqiannan/amory/doris/be/src/vec/exec/format/json/new_json_reader.cpp:347 8# doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0::operator()() const at /mnt/disk1/wangqiannan/amory/doris/be/src/service/internal_service.cpp:832 9# void std::__invoke_impl<void, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&>(std::__invoke_other, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61 10# std::enable_if<is_invocable_r_v<void, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&>, void>::type std::__invoke_r<void, doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&>(doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:117 11# std::_Function_handler<void (), doris::PInternalService::fetch_table_schema(google::protobuf::RpcController*, doris::PFetchTableSchemaRequest const*, doris::PFetchTableSchemaResult*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291 12# std::function<void ()>::operator()() const at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560 13# doris::WorkThreadPool<false>::work_thread(int) at /mnt/disk1/wangqiannan/amory/doris/be/src/util/work_thread_pool.hpp:158 14# void std::__invoke_impl<void, void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&>(std::__invoke_memfun_deref, void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:74 15# std::__invoke_result<void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&>::type std::__invoke<void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&>(void (doris::WorkThreadPool<false>::* const&)(int), doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96 16# decltype (std::__invoke((*this)._M_pmf, std::forward<doris::WorkThreadPool<false>*&>({parm#1}), std::forward<int&>({parm#1}))) std::_Mem_fn_base<void (doris::WorkThreadPool<false>::*)(int), true>::operator()<doris::WorkThreadPool<false>*&, int&>(doris::WorkThreadPool<false>*&, int&) const at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:131 17# void std::__invoke_impl<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&>(std::__invoke_other, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61 18# std::enable_if<is_invocable_r_v<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&>, void>::type std::__invoke_r<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&>(std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)>&, doris::WorkThreadPool<false>*&, int&) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:117 19# void std::_Bind_result<void, std::_Mem_fn<void (doris::WorkThreadPool<false>::*)(int)> (doris::WorkThreadPool<false>*, int)>::__call<void, , 0ul, 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) at /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:570 ```

Cherry-picked from #41290 Co-authored-by: amory <wangqiannan@selectdb.com>

fix new_json_reader core

b6fd419

dataroaring added dev/2.1.x dev/3.0.x labels Sep 25, 2024

eldenmoon previously approved these changes Sep 26, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024

github-actions bot added the reviewed label Sep 26, 2024

xiaokang reviewed Sep 26, 2024

View reviewed changes

Merge branch 'master' into fix-new-json-reader-core

7ab2f15

Update test_json_reader_without_object.groovy

01a601b

amorynan dismissed eldenmoon’s stale review via 01a601b November 1, 2024 08:06

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 1, 2024

eldenmoon previously approved these changes Nov 1, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2024

Merge branch 'master' into fix-new-json-reader-core

5f17be4

add error msg for data type

9a95c48

amorynan dismissed eldenmoon’s stale review via 9a95c48 November 3, 2024 11:00

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 3, 2024

xiaokang approved these changes Nov 3, 2024

View reviewed changes

xiaokang added the dev/2.0.x label Nov 3, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 3, 2024

eldenmoon approved these changes Nov 4, 2024

View reviewed changes

xiaokang merged commit 144198a into apache:master Nov 4, 2024

github-actions bot mentioned this pull request Nov 4, 2024

branch-3.0: [fix](new_json_reader)fix new_json_reader core #43187

Merged

github-actions bot mentioned this pull request Nov 4, 2024

branch-2.1: [fix](new_json_reader)fix new_json_reader core #43188

Merged

dataroaring pushed a commit that referenced this pull request Nov 7, 2024

branch-3.0: [fix](new_json_reader)fix new_json_reader core (#43187)

15a8ab5

Cherry-picked from #41290 Co-authored-by: amory <wangqiannan@selectdb.com>

dataroaring added dev/3.0.3-merged and removed dev/3.0.x labels Nov 7, 2024

yiguolei pushed a commit that referenced this pull request Nov 9, 2024

branch-2.1: [fix](new_json_reader)fix new_json_reader core (#43188)

fefc8a8

Cherry-picked from #41290 Co-authored-by: amory <wangqiannan@selectdb.com>

yiguolei added dev/2.1.8-merged and removed dev/2.1.x labels Nov 9, 2024

[fix](new_json_reader)fix new_json_reader core #41290

[fix](new_json_reader)fix new_json_reader core #41290

Uh oh!

Conversation

amorynan commented Sep 25, 2024

Proposed changes

Uh oh!

doris-robot commented Sep 25, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 26, 2024

Uh oh!

github-actions bot commented Sep 26, 2024

Uh oh!

amorynan commented Sep 26, 2024

Uh oh!

doris-robot commented Sep 26, 2024

Uh oh!

xiaokang Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

xiaokang Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

amorynan Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

xiaokang Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amorynan Nov 3, 2024

Choose a reason for hiding this comment

Uh oh!

amorynan Nov 3, 2024

Choose a reason for hiding this comment

Uh oh!

amorynan commented Oct 12, 2024

Uh oh!

github-actions bot commented Oct 12, 2024

Uh oh!

doris-robot commented Oct 12, 2024

Uh oh!

amorynan commented Nov 1, 2024

Uh oh!

github-actions bot commented Nov 1, 2024

Uh oh!

doris-robot commented Nov 1, 2024

Uh oh!

amorynan commented Nov 1, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 1, 2024

Uh oh!

github-actions bot commented Nov 3, 2024

Uh oh!

amorynan commented Nov 3, 2024

Uh oh!

github-actions bot commented Nov 3, 2024

Uh oh!

doris-robot commented Nov 3, 2024

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 3, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

xiaokang Nov 1, 2024 •

edited

Loading