-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix] (inverted index) fix the error result in the query when using count on index #41375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41043 ms |
TPC-DS: Total hot run time: 193061 ms |
ClickBench: Total hot run time: 32.28 s |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 40917 ms |
TPC-DS: Total hot run time: 191444 ms |
ClickBench: Total hot run time: 32.96 s |
|
run buildall |
TPC-H: Total hot run time: 40386 ms |
TPC-DS: Total hot run time: 191944 ms |
ClickBench: Total hot run time: 32.93 s |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ount on index (apache#41375) ## Proposed changes ``` select count(b) from table where b = 30 or c = 20; ``` - we should read column b - Rules for count on index: count is limited to types like count(*) and count(b), and in the query conditions, only count columns are connected using OR. - If the query conditions connected by OR include other columns, then it is not a count on index. - `select count(b) from table where b = 30 or c = 20;` is not a count on index, but `select count(b) from table where b = 30 or b > 200; ` is a count on index.
…ount on index (apache#41375) ## Proposed changes ``` select count(b) from table where b = 30 or c = 20; ``` - we should read column b - Rules for count on index: count is limited to types like count(*) and count(b), and in the query conditions, only count columns are connected using OR. - If the query conditions connected by OR include other columns, then it is not a count on index. - `select count(b) from table where b = 30 or c = 20;` is not a count on index, but `select count(b) from table where b = 30 or b > 200; ` is a count on index.
…ount on index (apache#41375) ## Proposed changes ``` select count(b) from table where b = 30 or c = 20; ``` - we should read column b - Rules for count on index: count is limited to types like count(*) and count(b), and in the query conditions, only count columns are connected using OR. - If the query conditions connected by OR include other columns, then it is not a count on index. - `select count(b) from table where b = 30 or c = 20;` is not a count on index, but `select count(b) from table where b = 30 or b > 200; ` is a count on index.
…ount on index (apache#42346) ## Proposed changes introduced by apache#41375
…ount on index (apache#42346) introduced by apache#41375
Proposed changes
select count(b) from table where b = 30 or c = 20;is not a count on index, butselect count(b) from table where b = 30 or b > 200;is a count on index.