Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Sep 29, 2024

Proposed changes

the table row count is in 3 cases:

  1. injected row count
  2. analyzed row count + delta row count
  3. BE reported row count.

in previous pr #40529, we added delta row count in all 3 cases
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@englefly
Copy link
Contributor Author

run buildall

@englefly englefly changed the title [fix](nereids)delta row count only plus to analyzed row count, but to be reported row count [fix](nereids)do not add delta row count to BE reported row count Sep 29, 2024
@englefly
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@englefly englefly merged commit 958d638 into apache:master Oct 8, 2024
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
…ache#41464)

## Proposed changes
the table row count is in 3 cases:
1. injected row count
2. analyzed row count + delta row count
3. BE reported row count.

in previous pr apache#40529, we added delta row count in all 3 cases
Issue Number: close #xxx

<!--Describe your changes.-->
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
…ache#41464)

## Proposed changes
the table row count is in 3 cases:
1. injected row count
2. analyzed row count + delta row count
3. BE reported row count.

in previous pr apache#40529, we added delta row count in all 3 cases
Issue Number: close #xxx

<!--Describe your changes.-->
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
…ache#41464)

## Proposed changes
the table row count is in 3 cases:
1. injected row count
2. analyzed row count + delta row count
3. BE reported row count.

in previous pr apache#40529, we added delta row count in all 3 cases
Issue Number: close #xxx

<!--Describe your changes.-->
englefly added a commit that referenced this pull request Oct 22, 2024
## Proposed changes
pick  #40529 #41464 #40349

Issue Number: close #xxx

<!--Describe your changes.-->
englefly added a commit that referenced this pull request Oct 22, 2024
## Proposed changes
pick #41464 #40529 #40349 #39222
Issue Number: close #xxx

<!--Describe your changes.-->
@englefly englefly removed the dev/2.0.0 2.0.0 release label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants