Skip to content

[fix](cloud) enable_file_cache for cloud by default #41502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 3 commits into from
Oct 11, 2024
Merged

[fix](cloud) enable_file_cache for cloud by default #41502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2a2c90
[fix](cloud) enable_file_cache for cloud by default
dataroaring Sep 30, 2024
3b67860
fix
dataroaring Sep 30, 2024
38ba931
Update config.cpp
dataroaring Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions be/src/common/config.cpp
View file
Open in desktop
Copy link
Contributor

@cjj2010 cjj2010 Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be modified to “auto st = config::set_config("enable_file_cache", "true", true, true);”

Original file line number Diff line number Diff line change
Expand Up @@ -1683,6 +1683,13 @@ bool init(const char* conf_file, bool fill_conf_map, bool must_exist, bool set_t
SET_FIELD(it.second, std::vector<std::string>, fill_conf_map, set_to_default);
}

if (config::is_cloud_mode()) {
auto st = config::set_config("enable_file_cache", "true", true, true);
LOG(INFO) << "set config enable_file_cache "
<< "true"
<< " " << st;
}

return true;
}

Expand Down