Skip to content

[2.1][fix](oracle scan) Fix performance issues caused by version judgment #41509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Oct 1, 2024
Merged

[2.1][fix](oracle scan) Fix performance issues caused by version judgment #41509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/OracleJdbcExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@
public class OracleJdbcExecutor extends BaseJdbcExecutor {
private static final Logger LOG = Logger.getLogger(OracleJdbcExecutor.class);
private final CharsetDecoder utf8Decoder = StandardCharsets.UTF_8.newDecoder();
private final boolean isNewJdbcVersion;

public OracleJdbcExecutor(byte[] thriftParams) throws Exception {
super(thriftParams);
isNewJdbcVersion = isJdbcVersionGreaterThanOrEqualTo("12.2.0");
}

@Override
Expand All @@ -65,7 +67,7 @@ protected void initializeBlock(int columnCount, String[] replaceStringList, int

@Override
protected Object getColumnValue(int columnIndex, ColumnType type, String[] replaceStringList) throws SQLException {
if (isJdbcVersionGreaterThanOrEqualTo("12.2.0")) {
if (isNewJdbcVersion) {
return newGetColumnValue(columnIndex, type, replaceStringList);
} else {
return oldGetColumnValue(columnIndex, type, replaceStringList);
Expand Down