Skip to content

[opt](Nereids) use 1 instead narrowest column when do column pruning #41548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 9, 2024
Merged

[opt](Nereids) use 1 instead narrowest column when do column pruning #41548

morrySnow merged 1 commit into from
Oct 9, 2024

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Oct 8, 2024

No description provided.

@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 8, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 8, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow morrySnow force-pushed the optimize_column_pruning branch from 9454ee5 to a26803f Compare October 8, 2024 11:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@morrySnow morrySnow force-pushed the optimize_column_pruning branch from a26803f to 1331bf9 Compare October 8, 2024 12:10
@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2024

TeamCity be ut coverage result:
Function Coverage: 37.28% (9631/25834)
Line Coverage: 28.68% (79886/278581)
Region Coverage: 28.10% (41292/146928)
Branch Coverage: 24.73% (21038/85084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1331bf904e58cf2969e98377059d595a1e74791c_1331bf904e58cf2969e98377059d595a1e74791c/report/index.html

@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 9, 2024

run cloud_p0

@morrySnow morrySnow requested a review from starocean999 October 9, 2024 02:10
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit e8336c4 into apache:master Oct 9, 2024
@morrySnow morrySnow deleted the optimize_column_pruning branch October 9, 2024 03:26
@morrySnow morrySnow mentioned this pull request Oct 9, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 9, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
48dbda2 
…pache#41548)

pick from master apache#41548
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 9, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
be034ae 
…pache#41548)

pick from master apache#41548
@morrySnow morrySnow mentioned this pull request Oct 9, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 10, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
adce7ec 
…pache#41548)

pick from master apache#41548
morrySnow added a commit that referenced this pull request Oct 10, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (#…
33fad04 
…41548) (#41627)

pick from master #41548
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@morrySnow @eldenmoon
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
84b9678 
…pache#41548)
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 11, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on union
01c7694 
just like previous PR apache#41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
@morrySnow morrySnow mentioned this pull request Oct 11, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 11, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on union
82b0504 
just like previous PR apache#41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@morrySnow @cjj2010
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
06308f2 
…pache#41548)
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
ec2f5de 
…pache#41548)
morrySnow added a commit that referenced this pull request Oct 14, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on un…
5ebfed9 
…ion (#41719)

just like previous PR #41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
qzsee pushed a commit to qzsee/incubator-doris that referenced this pull request Oct 16, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on un…
20420d2 
…ion (apache#41719)

just like previous PR apache#41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 16, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on un…
477a7db 
…ion (apache#41719)

pick from master apache#41719

just like previous PR apache#41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
@morrySnow morrySnow mentioned this pull request Oct 16, 2024
Merged
morrySnow added a commit that referenced this pull request Oct 17, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on un…
3fcd643 
…ion (#41719) (#41975)

pick from master #41719

just like previous PR #41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 24, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
52fc7cf 
…pache#41548)

pick from master apache#41548
@morrySnow morrySnow mentioned this pull request Oct 24, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (a…
e85ebaf 
…pache#41548)

pick from master apache#41548
morrySnow added a commit that referenced this pull request Oct 29, 2024
@morrySnow
[opt](Nereids) use 1 instead narrowest column when do column pruning (#…
52a0484 
…41548) (#42376)

pick from master #41548
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 29, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on un…
3399b03 
…ion (apache#41719)

pick from master apache#41719

just like previous PR apache#41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
@morrySnow morrySnow mentioned this pull request Oct 29, 2024
Merged
morrySnow added a commit that referenced this pull request Oct 29, 2024
@morrySnow
[opt](Nereids) use 1 as narrowest column when do column pruning on un…
189e94f 
…ion (#41719) (#42860)

pick from master #41719

just like previous PR #41548

this PR process union node to ensure not require any column from its
children when it is required by its parent with empty slot set
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Closed
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@xzj7019 xzj7019 xzj7019 approved these changes

@starocean999 starocean999 Awaiting requested review from starocean999

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @doris-robot @HappenLee @xzj7019