Skip to content

[Enhancement](inverted index) return OK instead of not supported in expr evaluate_inverted_index #41567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airborne12 merged 1 commit into from
Oct 9, 2024
Merged

[Enhancement](inverted index) return OK instead of not supported in expr evaluate_inverted_index #41567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/vec/exprs/vexpr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class VExpr {

// execute current expr with inverted index to filter block. Given a roaring bitmap of match rows
virtual Status evaluate_inverted_index(VExprContext* context, uint32_t segment_num_rows) {
return Status::NotSupported("Not supported execute_with_inverted_index");
return Status::OK();
Copy link
Contributor

@xiaokang xiaokang Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment for semantics of just returning OK()

}

Status _evaluate_inverted_index(VExprContext* context, const FunctionBasePtr& function,
Expand Down
3 changes: 1 addition & 2 deletions be/src/vec/functions/function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,7 @@ class IFunctionBase {
const std::vector<vectorized::IndexFieldNameAndTypePair>& data_type_with_names,
std::vector<segment_v2::InvertedIndexIterator*> iterators, uint32_t num_rows,
segment_v2::InvertedIndexResultBitmap& bitmap_result) const {
return Status::NotSupported("evaluate_inverted_index is not supported in function: ",
get_name());
return Status::OK();
}

/// Do cleaning work when function is finished, i.e., release state variables in the
Expand Down