Skip to content

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Oct 8, 2024

pick #41554 to branch-2.1

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

cambyzju commented Oct 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.10% (9340/25874)
Line Coverage: 27.66% (76722/277328)
Region Coverage: 26.45% (39376/148874)
Branch Coverage: 23.23% (20030/86224)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6414998d1c8bb9d8f072411ffd64d34043b32b35_6414998d1c8bb9d8f072411ffd64d34043b32b35/report/index.html

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by anyone and no changes requested.

@lide-reed lide-reed merged commit 0185f80 into apache:branch-2.1 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants