Skip to content

[fix](nereids)adjust agg function nullability in PhysicalHashAggregate #41576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 3 commits into from
Oct 14, 2024
Merged

[fix](nereids)adjust agg function nullability in PhysicalHashAggregate #41576

starocean999 merged 3 commits into from
Oct 14, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 9, 2024

Proposed changes

select sum(distinct c1) from t;
assume c1 is not null, because there is no group by, sum(distinct c1)'s nullable is alwasNullable in rewritten phase. But in implementation phase, we may create 3 phase agg with group by key c1. And the sum(distinct c1)'s nullability should be changed depending on if there is any group by expressions. This pr update the agg function's nullability accordingly

@doris-robot
Copy link

doris-robot commented Oct 9, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 9, 2024

run buildall

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 9, 2024

run buildall

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 9, 2024

run buildall

@starocean999 starocean999 marked this pull request as ready for review October 10, 2024 06:45
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR approved by anyone and no changes requested.

zhiqiang-hhhh
zhiqiang-hhhh approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starocean999 starocean999 merged commit 929da74 into apache:master Oct 14, 2024
@starocean999 starocean999 mentioned this pull request Oct 15, 2024
Merged
starocean999 added a commit that referenced this pull request Oct 16, 2024
@starocean999
[fix](nereids)adjust agg function nullability in PhysicalHashAggregate (
d786bd5 
#41900)

## Proposed changes

pick from master #41576

<!--Describe your changes.-->
@starocean999 starocean999 mentioned this pull request Oct 16, 2024
Merged
starocean999 added a commit that referenced this pull request Oct 17, 2024
@starocean999
[fix](nereids)modify agg function nullability in PhysicalHashAggregate (
64fd929 
#41943)

## Proposed changes

this is a follow up pr of #41576 ,
the previous pr may miss some agg function in AggregateExpression, this
pr fix it.

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@starocean999 @doris-robot @zhiqiang-hhhh @morrySnow @yiguolei