Skip to content

[fix](is_exclusive) fix is_exlusive func for nested types #41646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 5 commits into from
Oct 15, 2024
Merged

[fix](is_exclusive) fix is_exlusive func for nested types #41646

eldenmoon merged 5 commits into from
Oct 15, 2024
+141 −0

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Oct 10, 2024

Proposed changes

backport: #40398
Issue Number: close #xxx

amory added 2 commits October 10, 2024 11:55
[fix](nestedtype)fix nested type with is_exclusive (apache#40398)
ce0d972 
is_exclusive in column_array/map/struct has wrong semantic , we should
make sure it's nested column is also is_exclusive which can make
behavior right in some operator like join.
revert columnobject
c62e31f
@doris-robot
Copy link

doris-robot commented Oct 10, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

amorynan commented Oct 10, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@doris-robot
Copy link

doris-robot commented Oct 10, 2024

TeamCity be ut coverage result:
Function Coverage: 37.81% (8148/21549)
Line Coverage: 29.55% (67076/226974)
Region Coverage: 29.02% (34578/119140)
Branch Coverage: 24.94% (17819/71458)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c62e31fe927cf61245d8b5ff8f97db74e5135c93_c62e31fe927cf61245d8b5ff8f97db74e5135c93/report/index.html

@amorynan
Copy link
Contributor Author

amorynan commented Oct 10, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 10, 2024

TeamCity be ut coverage result:
Function Coverage: 37.82% (8150/21549)
Line Coverage: 29.56% (67095/226978)
Region Coverage: 29.03% (34590/119140)
Branch Coverage: 24.94% (17824/71458)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ee50993b9149fe50141c5f82b93d27326eb7a9aa_ee50993b9149fe50141c5f82b93d27326eb7a9aa/report/index.html

@amorynan
Copy link
Contributor Author

amorynan commented Oct 11, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2024

TeamCity be ut coverage result:
Function Coverage: 37.82% (8150/21552)
Line Coverage: 29.56% (67092/227006)
Region Coverage: 29.03% (34584/119146)
Branch Coverage: 24.94% (17821/71460)
Coverage Report: http://coverage.selectdb-in.cc/coverage/13c062370da89eaf896aee2b0a524cd409bfc952_13c062370da89eaf896aee2b0a524cd409bfc952/report/index.html

@amorynan
Copy link
Contributor Author

amorynan commented Oct 12, 2024

run p0

1 similar comment
@amorynan
Copy link
Contributor Author

amorynan commented Oct 12, 2024

run p0

xiaokang
xiaokang requested changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add testcase

@amorynan
Copy link
Contributor Author

amorynan commented Oct 14, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/vec/core/column_test.cpp
// specific language governing permissions and limitations
// under the License.

#include <gtest/gtest.h>
Copy link
Contributor

@github-actions github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@doris-robot
Copy link

doris-robot commented Oct 14, 2024

TeamCity be ut coverage result:
Function Coverage: 37.84% (8155/21552)
Line Coverage: 29.56% (67103/227016)
Region Coverage: 29.04% (34600/119156)
Branch Coverage: 24.95% (17829/71468)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54c6610da40ba2c1d6ab86eddd58437e9c1044d3_54c6610da40ba2c1d6ab86eddd58437e9c1044d3/report/index.html

eldenmoon
eldenmoon approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 3ab97fb into apache:branch-2.0 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@xiaokang xiaokang xiaokang requested changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees

No one assigned

Labels

kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amorynan @doris-robot @xiaokang @eldenmoon