-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](bug) Is null predicate get error query result #41668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| end_scan_keys.back().add_value( | ||
| cast_to_string<primitive_type, CppType>(get_range_max_value(), scale())); | ||
| cast_to_string<primitive_type, CppType>(get_range_max_value(), scale()), | ||
| empty_range_only_null ? true : false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]
| empty_range_only_null ? true : false); | |
| static_cast<bool>(empty_range_only_null)); |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
|
run buildall |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
TeamCity be ut coverage result: |
### What problem does this PR solve? cherry pick #41668
Proposed changes
Fix Before Error Query Result: