Skip to content

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

Fix Before Error Query Result:

create table t(a int, b int) duplicate key(`a`, `b`) DISTRIBUTED BY RANDOM BUCKETS AUTO PROPERTIES ( "replication_allocation" = "tag.location.default: 1");
insert into t values(-2147483648, -2147483648);
mysql> select * from t where a is null;
+-------------+-------------+
| a           | b           |
+-------------+-------------+
| -2147483648 | -2147483648 |
+-------------+-------------+
1 row in set (0.03 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee HappenLee added dev/2.0.x dev/2.1.x dev/3.0.x kind/fix Categorizes issue or PR as related to a bug. labels Oct 10, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

end_scan_keys.back().add_value(
cast_to_string<primitive_type, CppType>(get_range_max_value(), scale()));
cast_to_string<primitive_type, CppType>(get_range_max_value(), scale()),
empty_range_only_null ? true : false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]

Suggested change
empty_range_only_null ? true : false);
static_cast<bool>(empty_range_only_null));

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.41% (9660/25825)
Line Coverage: 28.69% (80170/279471)
Region Coverage: 28.11% (41441/147415)
Branch Coverage: 24.71% (21105/85400)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5215135fb97c68f69d3513f949f57ed09629485d_5215135fb97c68f69d3513f949f57ed09629485d/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.40% (9660/25827)
Line Coverage: 28.69% (80176/279495)
Region Coverage: 28.10% (41441/147462)
Branch Coverage: 24.71% (21111/85426)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae2ec442dcba902471df7e46af353a16611aa9eb_ae2ec442dcba902471df7e46af353a16611aa9eb/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.7-merged dev/3.0.3-merged kind/fix Categorizes issue or PR as related to a bug. p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants