Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Oct 11, 2024

backport: #41595
this resize function called shrink function which defined in IColumn, and function set_num_rows in Block.cpp call shrink to make column rows changed, maybe less or more.
In this situation if we would make less rows which like cut the rows, so we should also make nested data in array/map resize to the less number of rows , otherwise we will meet exception

Proposed changes

Issue Number: close #xxx

this resize function called shrink function which defined in IColumn,
and function set_num_rows in Block.cpp call shrink to make column rows
changed, maybe less or more.
In this situation if we would make less rows which like cut the rows, so
we should also make nested data in array/map resize to the less number
of rows , otherwise we will meet exception
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.07% (9339/25893)
Line Coverage: 27.65% (76731/277511)
Region Coverage: 26.45% (39404/148992)
Branch Coverage: 23.24% (20053/86292)
Coverage Report: http://coverage.selectdb-in.cc/coverage/322036f2bf379b7d8320a5f460693e0569d66f08_322036f2bf379b7d8320a5f460693e0569d66f08/report/index.html

@amorynan
Copy link
Contributor Author

run p0

1 similar comment
@amorynan
Copy link
Contributor Author

run p0

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.04% (9340/25919)
Line Coverage: 27.61% (76702/277848)
Region Coverage: 26.41% (39403/149171)
Branch Coverage: 23.21% (20050/86402)
Coverage Report: http://coverage.selectdb-in.cc/coverage/71d1a031afc09c99b846ea7ce9f62b876b7412bc_71d1a031afc09c99b846ea7ce9f62b876b7412bc/report/index.html

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 94687a2 into apache:branch-2.1 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants