Skip to content

[improvement](jdbc catalog) Print more errors when Jdbc Catalog fails to obtain a connection on FE #41735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Oct 12, 2024
Merged

[improvement](jdbc catalog) Print more errors when Jdbc Catalog fails to obtain a connection on FE #41735

morningman merged 2 commits into from
Oct 12, 2024

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Oct 11, 2024

We need to print more detailed error information when Jdbc Catalog obtains a connection to facilitate troubleshooting

@doris-robot
Copy link

doris-robot commented Oct 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Oct 11, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2024

TPC-H: Total hot run time: 40474 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b52dee915060c3125223eda9d4c8c304d39f93f, data reload: false

------ Round 1 ----------------------------------
q1	17564	8162	7237	7237
q2	2042	278	275	275
q3	12106	1075	1196	1075
q4	10548	739	682	682
q5	7732	2875	2758	2758
q6	235	152	151	151
q7	999	634	606	606
q8	9351	1905	1949	1905
q9	6527	6479	6397	6397
q10	6984	2311	2323	2311
q11	432	255	243	243
q12	414	226	219	219
q13	17783	2984	2973	2973
q14	242	211	212	211
q15	570	529	523	523
q16	650	574	587	574
q17	973	505	537	505
q18	7169	6615	6698	6615
q19	1348	936	942	936
q20	469	201	196	196
q21	4247	3106	3266	3106
q22	1094	979	976	976
Total cold run time: 109479 ms
Total hot run time: 40474 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7253	7198	7199	7198
q2	331	234	231	231
q3	2973	2904	2935	2904
q4	2123	1861	1811	1811
q5	5687	5746	5702	5702
q6	239	149	152	149
q7	2232	1847	1813	1813
q8	3374	3539	3442	3442
q9	8878	8747	8836	8747
q10	3563	3532	3489	3489
q11	585	505	488	488
q12	852	605	615	605
q13	9945	3169	3190	3169
q14	296	297	278	278
q15	592	523	523	523
q16	702	623	637	623
q17	1820	1627	1592	1592
q18	8305	7717	7452	7452
q19	1701	1418	1602	1418
q20	2144	1856	1899	1856
q21	5551	5404	5370	5370
q22	1152	1083	1044	1044
Total cold run time: 70298 ms
Total hot run time: 59904 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2024

TPC-DS: Total hot run time: 191885 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b52dee915060c3125223eda9d4c8c304d39f93f, data reload: false

query1	882	393	407	393
query2	6288	2070	1997	1997
query3	8696	199	200	199
query4	34455	23930	23396	23396
query5	3487	478	467	467
query6	279	191	178	178
query7	4209	315	327	315
query8	294	224	228	224
query9	9383	2687	2682	2682
query10	441	297	290	290
query11	17862	15247	15186	15186
query12	156	102	97	97
query13	1578	459	441	441
query14	8447	7686	7361	7361
query15	262	172	174	172
query16	7863	442	412	412
query17	1720	625	608	608
query18	1744	305	325	305
query19	362	163	160	160
query20	122	114	110	110
query21	211	106	105	105
query22	4894	4682	4665	4665
query23	34779	33920	34071	33920
query24	10942	2847	2819	2819
query25	655	419	409	409
query26	1470	161	166	161
query27	2631	302	296	296
query28	7711	2418	2413	2413
query29	927	443	442	442
query30	257	148	160	148
query31	994	780	810	780
query32	95	57	55	55
query33	777	296	307	296
query34	961	501	500	500
query35	859	731	730	730
query36	1117	925	949	925
query37	151	103	86	86
query38	3974	3862	3900	3862
query39	1444	1423	1446	1423
query40	269	99	97	97
query41	48	43	45	43
query42	120	101	99	99
query43	520	486	466	466
query44	1259	811	801	801
query45	194	167	167	167
query46	1136	715	738	715
query47	1951	1803	1813	1803
query48	451	356	366	356
query49	943	415	403	403
query50	820	411	423	411
query51	7149	6825	7044	6825
query52	92	90	89	89
query53	259	179	177	177
query54	1240	499	474	474
query55	79	73	81	73
query56	275	263	262	262
query57	1264	1121	1145	1121
query58	232	228	244	228
query59	3270	2969	2986	2969
query60	281	269	271	269
query61	104	103	100	100
query62	876	679	656	656
query63	218	180	181	180
query64	4928	649	637	637
query65	3283	3191	3203	3191
query66	1311	314	305	305
query67	15965	15653	15692	15653
query68	4840	563	553	553
query69	443	296	301	296
query70	1187	1110	1068	1068
query71	349	276	283	276
query72	6984	4003	3966	3966
query73	771	365	342	342
query74	10181	9029	8917	8917
query75	3318	2639	2645	2639
query76	2617	908	903	903
query77	477	314	332	314
query78	10532	9577	9519	9519
query79	2572	594	598	594
query80	914	435	446	435
query81	578	238	235	235
query82	748	137	135	135
query83	268	137	138	137
query84	267	80	82	80
query85	1166	300	284	284
query86	306	307	298	298
query87	4401	4278	4279	4278
query88	4286	2446	2509	2446
query89	401	285	282	282
query90	2227	185	185	185
query91	137	107	104	104
query92	65	47	49	47
query93	1324	551	539	539
query94	974	295	304	295
query95	353	260	260	260
query96	607	283	280	280
query97	3220	3121	3114	3114
query98	214	196	191	191
query99	1659	1302	1275	1275
Total cold run time: 300302 ms
Total hot run time: 191885 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2024

ClickBench: Total hot run time: 32.86 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b52dee915060c3125223eda9d4c8c304d39f93f, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.02
query3	0.23	0.06	0.06
query4	1.65	0.11	0.10
query5	0.51	0.52	0.51
query6	1.13	0.73	0.74
query7	0.02	0.02	0.02
query8	0.03	0.03	0.04
query9	0.56	0.50	0.49
query10	0.58	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.10	0.11
query13	0.61	0.60	0.59
query14	2.72	2.73	2.73
query15	0.91	0.85	0.83
query16	0.39	0.37	0.39
query17	1.08	1.06	1.08
query18	0.20	0.20	0.20
query19	1.90	1.89	2.04
query20	0.02	0.02	0.01
query21	15.37	0.59	0.56
query22	2.67	2.00	1.94
query23	17.12	0.91	0.73
query24	3.27	1.08	1.20
query25	0.28	0.11	0.18
query26	0.52	0.13	0.14
query27	0.05	0.04	0.03
query28	10.44	1.10	1.08
query29	12.52	3.23	3.24
query30	0.24	0.06	0.06
query31	2.89	0.38	0.38
query32	3.27	0.46	0.46
query33	3.00	2.98	3.07
query34	17.24	4.43	4.46
query35	4.52	4.49	4.49
query36	0.66	0.48	0.48
query37	0.09	0.05	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.15	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.43 s
Total hot run time: 32.86 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

PR approved by anyone and no changes requested.

@morningman morningman mentioned this pull request Oct 12, 2024
Merged
morningman
morningman approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit a549f8c into apache:master Oct 12, 2024
qzsee pushed a commit to qzsee/incubator-doris that referenced this pull request Oct 16, 2024
@zy-kkk
[improvement](jdbc catalog) Print more errors when Jdbc Catalog fails…
c89fdcf 
… to obtain a connection on FE (apache#41735)

We need to print more detailed error information when Jdbc Catalog
obtains a connection to facilitate troubleshooting
morningman pushed a commit to morningman/doris that referenced this pull request Oct 21, 2024
@zy-kkk @morningman
[improvement](jdbc catalog) Print more errors when Jdbc Catalog fails…
87422aa 
… to obtain a connection on FE (apache#41735)

We need to print more detailed error information when Jdbc Catalog
obtains a connection to facilitate troubleshooting
@morningman morningman mentioned this pull request Oct 21, 2024
Merged
morningman added a commit that referenced this pull request Oct 21, 2024
@morningman @zy-kkk
[improvement](jdbc catalog) Print more errors when Jdbc Catalog fails…
de539ac 
… to obtain a connection on FE #41735 (#42181)

cherry pick from #41735

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
@zy-kkk zy-kkk deleted the more_jdbc_connection_log branch November 7, 2024 09:41
@zy-kkk zy-kkk removed the dev/2.0.x label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zy-kkk @doris-robot @morningman @CalvinKirs