Skip to content

[Fix](inverted index) fix match null for inverted index #41746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 3 commits into from
Oct 14, 2024
Merged

[Fix](inverted index) fix match null for inverted index #41746

airborne12 merged 3 commits into from
Oct 14, 2024

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Oct 12, 2024

Proposed changes

str match null return null , not true event if str is null

@doris-robot
Copy link

doris-robot commented Oct 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@airborne12
Copy link
Member Author

airborne12 commented Oct 12, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 12, 2024

TeamCity be ut coverage result:
Function Coverage: 37.39% (9658/25827)
Line Coverage: 28.68% (80173/279569)
Region Coverage: 28.09% (41438/147504)
Branch Coverage: 24.70% (21108/85454)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca8fe5b4472ed8d633848a47d74c1b2110227451_ca8fe5b4472ed8d633848a47d74c1b2110227451/report/index.html

@airborne12
Copy link
Member Author

airborne12 commented Oct 12, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 12, 2024

TeamCity be ut coverage result:
Function Coverage: 37.39% (9663/25844)
Line Coverage: 28.65% (80149/279789)
Region Coverage: 28.08% (41439/147554)
Branch Coverage: 24.70% (21101/85444)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6f5432be458246848fe3e56d93ad0b3b8e7ac445_6f5432be458246848fe3e56d93ad0b3b8e7ac445/report/index.html

eldenmoon
eldenmoon approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 14, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 6a6455d into apache:master Oct 14, 2024
@airborne12 airborne12 deleted the fix-null-index branch October 14, 2024 04:17
This was referenced Oct 14, 2024
Merged
Merged
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 14, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index (apache#41746)
e09c636 
## Proposed changes

str match null return null , not true event if str is null
airborne12 added a commit that referenced this pull request Oct 14, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index #41746 (#41787)
ff52e73 
cherry pick from #41746
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 16, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index (apache#41746)
355147c 
## Proposed changes

str match null return null , not true event if str is null
qzsee pushed a commit to qzsee/incubator-doris that referenced this pull request Oct 16, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index (apache#41746)
13d785c 
## Proposed changes

str match null return null , not true event if str is null
airborne12 added a commit that referenced this pull request Oct 16, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index #41746 (#41786)
eb6e834 
cherry pick from #41746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@airborne12 @doris-robot @eldenmoon @csun5285