Skip to content

[branch-2.1][improvement](jdbc catalog) Print more errors when Jdbc Catalog fails to obtain a connection on FE #41769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Oct 12, 2024
Merged

[branch-2.1][improvement](jdbc catalog) Print more errors when Jdbc Catalog fails to obtain a connection on FE #41769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ public Connection getConnection() throws JdbcClientException {
Thread.currentThread().setContextClassLoader(this.classLoader);
conn = dataSource.getConnection();
} catch (Exception e) {
String errorMessage = String.format("Can not connect to jdbc due to error: %s, Catalog name: %s",
e.getMessage(), this.getCatalogName());
String errorMessage = String.format(
"Catalog `%s` can not connect to jdbc due to error: %s",
this.getCatalogName(), JdbcClientException.getAllExceptionMessages(e));
throw new JdbcClientException(errorMessage, e);
} finally {
Thread.currentThread().setContextClassLoader(oldClassLoader);
Expand Down
15 changes: 15 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcClientException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,19 @@ private static Object[] escapePercentInArgs(Object... args) {
}
return escapedArgs;
}

public static String getAllExceptionMessages(Throwable throwable) {
StringBuilder sb = new StringBuilder();
while (throwable != null) {
String message = throwable.getMessage();
if (message != null && !message.isEmpty()) {
if (sb.length() > 0) {
sb.append(" | Caused by: ");
}
sb.append(message);
}
throwable = throwable.getCause();
}
return sb.toString();
}
}