Skip to content

[bug](function)fix date_floor function return wrong result #41948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 2 commits into from
Oct 17, 2024
Merged

[bug](function)fix date_floor function return wrong result #41948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a14c1ae
[bug](function)fix date_floor function return wrong result
zhangstar333 Oct 16, 2024
13fe604
update
zhangstar333 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions be/src/vec/functions/function_datetime_floor_ceil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <boost/iterator/iterator_facade.hpp>
#include <cstddef>
#include <cstdint>
#include <cstring>
#include <memory>
#include <type_traits>
#include <utility>
Expand Down Expand Up @@ -293,7 +294,7 @@ struct FloorCeilImpl {
PaddedPODArray<NativeType>& res, NullMap& null_map) {
// time_round(datetime,const(period))
if (period < 1) {
null_map.resize_fill(dates.size(), true);
memset(null_map.data(), 1, sizeof(UInt8) * dates.size());
return;
}
for (int i = 0; i < dates.size(); ++i) {
Expand Down Expand Up @@ -337,7 +338,7 @@ struct FloorCeilImpl {
NativeType origin_date, PaddedPODArray<NativeType>& res,
NullMap& null_map) {
if (period < 1) {
null_map.resize_fill(dates.size(), true);
memset(null_map.data(), 1, sizeof(UInt8) * dates.size());
return;
}
switch (period) {
Expand Down Expand Up @@ -424,7 +425,7 @@ struct FloorCeilImpl {
const PaddedPODArray<NativeType>& origin_dates,
PaddedPODArray<NativeType>& res, NullMap& null_map) {
if (period < 1) {
null_map.resize_fill(dates.size(), true);
memset(null_map.data(), 1, sizeof(UInt8) * dates.size());
return;
}
for (int i = 0; i < dates.size(); ++i) {
Expand Down
5 changes: 5 additions & 0 deletions regression-test/data/correctness_p0/test_time_round.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,8 @@
2020-02-02T11:45:14
2020-02-02T11:45:14

-- !select_1 --
2020-02-02T13:09:20 \N
2020-02-02T13:09:20 \N
2020-02-02T13:09:20 \N

1 change: 1 addition & 0 deletions regression-test/suites/correctness_p0/test_time_round.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,5 @@ suite("test_time_round") {
qt_select "select hour_floor(dt,2,o) from dbround order by id;"
qt_select "select hour_floor(dt,p,'1919-08-10 11:45:14') from dbround order by id;"
qt_select "select hour_floor(dt,2,'1919-08-10 11:45:14') from dbround order by id;"
qt_select_1 "select dt,hour_floor(dt,0) from dbround order by id;"
}