-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](index compaction) base compaction failed after restore indexes #41966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
lide-reed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run p0 |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run External Regression |
| // from src cluster in be, but in fe, we will generate new index_id, | ||
| // different index_id make we can not find index file correctly. | ||
| // Here we temporarily skip index compaction. | ||
| // (TODO) we should use index_id in rowset schema, not tablet schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to specify which part todo this
|
for branch-2.1: #43962 |
|
@cambyzju Why was this PR closed on the master branch? |
Problem:
after restore from other cluster, then rowsets got different index_id, and make index compaction in base compaction always failed.
Close this pr:
because of duplicate pr, #41625 already fix it: