Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

cherry pick from #41273

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

}

// After init function call, should not access _parent
Status ScannerContext::init() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'init' exceeds recommended size/complexity thresholds [readability-function-size]

Status ScannerContext::init() {
                       ^
Additional context

be/src/vec/exec/scan/scanner_context.cpp:77: 146 lines including whitespace and comments (threshold 80)

Status ScannerContext::init() {
                       ^

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the pick_41273_to_upstream_branch-2.1 branch from 79452fc to 3f10933 Compare October 17, 2024 09:43
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.01% (9345/25954)
Line Coverage: 27.59% (76787/278341)
Region Coverage: 26.39% (39437/149427)
Branch Coverage: 23.18% (20071/86604)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a81971d7e78c159c11058a3f8e8671c88fc1d3be_a81971d7e78c159c11058a3f8e8671c88fc1d3be/report/index.html

@yiguolei yiguolei force-pushed the pick_41273_to_upstream_branch-2.1 branch from a81971d to 9bb76ac Compare October 17, 2024 13:46
@yiguolei
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.01% (9347/25954)
Line Coverage: 27.58% (76779/278353)
Region Coverage: 26.40% (39451/149438)
Branch Coverage: 23.18% (20079/86610)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9bb76ac9ed804a6882650ce24e45bdbe94017c95_9bb76ac9ed804a6882650ce24e45bdbe94017c95/report/index.html

@yiguolei yiguolei merged commit 03136ba into apache:branch-2.1 Oct 18, 2024
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_41273_to_upstream_branch-2.1 branch October 24, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants