-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](scanner) Fix incorrect _max_thread_num in scanner context when many queries are running. #41273 #42016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](scanner) Fix incorrect _max_thread_num in scanner context when many queries are running. #41273 #42016
Conversation
|
run buildall |
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| } | ||
|
|
||
| // After init function call, should not access _parent | ||
| Status ScannerContext::init() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'init' exceeds recommended size/complexity thresholds [readability-function-size]
Status ScannerContext::init() {
^Additional context
be/src/vec/exec/scan/scanner_context.cpp:77: 146 lines including whitespace and comments (threshold 80)
Status ScannerContext::init() {
^79452fc to
3f10933
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
a81971d to
9bb76ac
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
cherry pick from #41273