[fix](move-memtable) abstract multi-streams to one logical stream #42039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41398 ms |
TPC-DS: Total hot run time: 191852 ms |
ClickBench: Total hot run time: 32.56 s |
kaijchen
force-pushed
the
DORIS-15521-followup
branch
from
b2b35e9 to
e6dc184
Compare
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41331 ms |
TPC-DS: Total hot run time: 192063 ms |
ClickBench: Total hot run time: 31.82 s |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41230 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 191416 ms |
ClickBench: Total hot run time: 32.61 s |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
kaijchen
force-pushed
the
DORIS-15521-followup
branch
from
3815d06 to
8bbd87e
Compare
kaijchen
force-pushed
the
DORIS-15521-followup
branch
from
8bbd87e to
8667d71
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41229 ms |
TPC-DS: Total hot run time: 192112 ms |
ClickBench: Total hot run time: 32.61 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 22, 2024
…ache#42039) ## Proposed changes Currently, an upstream BE (sink_v2) will open multiple streams to a downstream BE (load_stream). If any of the streams fails, the use_cnt on the downstream BE will be messed up. The load_stream will not report any success tablets to the sink_v2 since in its view there are still unfinished streams. So fault tolerance when open streams is not meaningful in practical, and may cause data lost. i.e. Upstream think there is still working streams to transfer data, but downstream does not report any commit info. This PR removes fault tolerance when open multiple streams to the same backend. If any of the open fails, the upstream sink_v2 should mark the downstream BE as failed replicas.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 22, 2024
…ache#42039) Currently, an upstream BE (sink_v2) will open multiple streams to a downstream BE (load_stream). If any of the streams fails, the use_cnt on the downstream BE will be messed up. The load_stream will not report any success tablets to the sink_v2 since in its view there are still unfinished streams. So fault tolerance when open streams is not meaningful in practical, and may cause data lost. i.e. Upstream think there is still working streams to transfer data, but downstream does not report any commit info. This PR removes fault tolerance when open multiple streams to the same backend. If any of the open fails, the upstream sink_v2 should mark the downstream BE as failed replicas.
liaoxin01
pushed a commit
that referenced
this pull request
Oct 22, 2024
liaoxin01
pushed a commit
that referenced
this pull request
Oct 22, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 25, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 25, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 25, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 25, 2024
liaoxin01
pushed a commit
that referenced
this pull request
Oct 25, 2024
yiguolei
pushed a commit
that referenced
this pull request
Oct 25, 2024
liaoxin01
pushed a commit
that referenced
this pull request
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, an upstream BE (sink_v2) will open multiple streams to a downstream BE (load_stream).
If any of the streams fails, the use_cnt on the downstream BE will be messed up.
The load_stream will not report any success tablets to the sink_v2 since in its view there are still unfinished streams.
So fault tolerance when open streams is not meaningful in practical, and may cause data lost.
i.e. Upstream think there is still working streams to transfer data, but downstream does not report any commit info.
This PR removes fault tolerance when open multiple streams to the same backend.
If any of the open fails, the upstream sink_v2 should mark the downstream BE as failed replicas.