[fix](inverted index) Fix errors caused by enable_need_read_data_opt #42064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
csun5285
force-pushed
the
test_decimal_index
branch
from
bf9369d to
0ba83ba
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Oct 22, 2024
924060929
reviewed
Oct 22, 2024
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java
Show resolved
Hide resolved
924060929
changed the title
airborne12
pushed a commit
to airborne12/apache-doris
that referenced
this pull request
Oct 22, 2024
…pache#42064) ## Proposed changes In the current backend implementation, it is not correctly handle counts when `is null` predicate exists, so we forbid the storage layer's count currently. for example: ``` select count(b) from test where b is null ``` When apply the is null filter, the result array will fill the default value of the column type and the count operator can not detect whether the result is null, so the count operator compute the wrong result.
airborne12
added a commit
that referenced
this pull request
Oct 23, 2024
airborne12
added a commit
that referenced
this pull request
Oct 23, 2024
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Oct 24, 2024
…pache#42064) ## Proposed changes In the current backend implementation, it is not correctly handle counts when `is null` predicate exists, so we forbid the storage layer's count currently. for example: ``` select count(b) from test where b is null ``` When apply the is null filter, the result array will fill the default value of the column type and the count operator can not detect whether the result is null, so the count operator compute the wrong result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the current backend implementation, it is not correctly handle counts when
is nullpredicate exists, so we forbid the storage layer's count currently.for example:
When apply the is null filter, the result array will fill the default value of the column type and the count operator can not detect whether the result is null, so the count operator compute the wrong result.