Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Oct 21, 2024

If use explicit transactions, error messages may display inaccurately:

mysql> begin;
Query OK, 0 rows affected (0.00 sec)
{'label':'txn_insert_df15d2c71f594be9-a7cbb425b53316b4', 'status':'PREPARE', 'txnId':''}

mysql> insert into test_begin_insert_mow1 values (13, false, 621, 723115.801, "c5","2024-10-15","2024-10-15", "c8", 1.1234, "c10");
Query OK, 1 rows affected (0.04 sec)
{'label':'txn_insert_df15d2c71f594be9-a7cbb425b53316b4', 'status':'PREPARE', 'txnId':'XXX'}

mysql> commit;
ERROR 1105 (HY000): errCode = 2, detailMessage = User Abort

But actually, it is DATA_QUALITY_ERROR. The reason is:
explicit transactions reuses the logic of stream load, but when stream load aborts transactions, it will not submit error messages to meta service.

Fix result:

mysql> begin;
Query OK, 0 rows affected (0.00 sec)
{'label':'txn_insert_bebe57d15b7b4462-93bc160c3580d47f', 'status':'PREPARE', 'txnId':''}

mysql> insert into test_begin_insert_mow1 values (13, false, 621, 723115.801, "c5","2024-10-15","2024-10-15", "c8", 1.1234, "c10");
Query OK, 1 rows affected (0.04 sec)
{'label':'txn_insert_bebe57d15b7b4462-93bc160c3580d47f', 'status':'PREPARE', 'txnId':'XXX'}

mysql> commit;
ERROR 1105 (HY000): errCode = 2, detailMessage = [DATA_QUALITY_ERROR]too many filtered rows

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented Oct 21, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.75% (80650/280522)
Region Coverage: 28.18% (41717/148045)
Branch Coverage: 24.76% (21210/85656)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e5bb783ba3073c339e524c34bf61dd277d560771_e5bb783ba3073c339e524c34bf61dd277d560771/report/index.html

@sollhui
Copy link
Contributor Author

sollhui commented Oct 21, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.48% (9709/25902)
Line Coverage: 28.75% (80624/280438)
Region Coverage: 28.20% (41731/147986)
Branch Coverage: 24.77% (21214/85636)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a99c1adc3dd706eef4674a7b15f80527ea9e4261_a99c1adc3dd706eef4674a7b15f80527ea9e4261/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants