[Bug][Load][Json] #4124 Load json format with stream load failed #4217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
area/load
wuyunfeng
reviewed
Jul 31, 2020
| // CONF_Int64(mini_load_max_mb, "2048"); | ||
| CONF_Int32(number_tablet_writer_threads, "16"); | ||
|
|
||
| // The maximum amount of data that can be processed by a stream load |
Member
There was a problem hiding this comment.
a stream load can process 10G by default?
Contributor
Author
There was a problem hiding this comment.
Actually, this default value is too big for a stream load.
But I am not going to modify this to avoid some user troubles.
be/src/http/action/stream_load.cpp
Outdated
| if (ctx->format == TFileFormatType::FORMAT_JSON) { | ||
| if (ctx->body_bytes > max_body_bytes) { | ||
| std::stringstream ss; | ||
| ss << "body exceed max size of json format: " << ctx->body_bytes << ", limit: " << max_body_bytes; |
Member
There was a problem hiding this comment.
the size of this batch exceed the max size of json type data
Suggested change
| ss << "body exceed max size of json format: " << ctx->body_bytes << ", limit: " << max_body_bytes; | |
| ss << "the size of this batch exceed the max size [" << max_body_bytes << "] of json type data " << " data [ " << ctx->body_bytes << " ] " |
And I suggest you should truncate the logged body_bytes such as just show 1024 byte
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Aug 11, 2020
apache#4217) Stream load should read all the data completely before parsing the json. And also add a new BE config streaming_load_max_batch_read_mb to limit the data size when loading json data. Fix the bug of loading empty json array [] Add doc to explain some certain case of loading json format data. Fix: apache#4124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Stream load should read all the data completely before parsing the json.
And also add a new BE config
streaming_load_max_batch_read_mbto limit the data size when loading json data.
Fix the bug of loading empty json array
[]Add doc to explain some certain case of loading json format data.
Fix: #4124
Types of changes
Checklist