[enhance](hive) Add regression-test cases for hive text ddl and hive text insert and fix reading null string bug #42200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
Author
|
run external |
suxiaogang223
force-pushed
the
add_case_for_hive_text
branch
from
92b7ecb to
74df02b
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
suxiaogang223
changed the title
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
CalvinKirs
approved these changes
Oct 22, 2024
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Oct 22, 2024
…text insert and fix reading null string bug (apache#42200) ## Proposed changes Add regression-test cases for hive text table properties: | **Property** | **Description** | **Example Value** | **Supported in Doris** | |------------------------------|---------------------------------------------------------------------|-------------------|----------------------| | `field.delim` | Defines the delimiter between columns in each row. | `\1` | Yes | | `collection.delim` | Defines the delimiter for items in an array (collection type). | `\2` | Yes | | `mapkey.delim` | Defines the delimiter between keys and values in a map. | `\3` | Yes | | `serialization.null.format` | Defines how `NULL` values are represented in the text file. | `\\N` | Yes | | `escape.delim` | Specifies the escape character used for escaping special characters.| `\\` | Yes | | `line.delim` | Defines the delimiter between rows or lines in the file. | `\n` | Yes | ### Explanation: - **`field.delim`**: This property is used to specify how columns are separated in a row. For example, `\1` indicates the delimiter is a non-printable character. - **`collection.delim`**: Used to define how elements in an array or collection are separated. In this case, `\2` is used as a separator. - **`mapkey.delim`**: This property defines how keys and values in a map are separated. For instance, `\3` is used to separate map keys and values. - **`serialization.null.format`**: This setting specifies the format for `NULL` values in the data. `\\N` is commonly used to represent `NULL`. - **`escape.delim`**: Defines the escape character used in the text file for escaping special characters, such as the delimiter itself. Here, `\\` is used as the escape character. - **`line.delim`**: This property is used to specify the delimiter between lines or rows. Typically, `\n` (newline) is used as the line delimiter. **Note**: Unlike the other delimiters, `line.delim` is not escaped. If the content in the table contains the same character as the line delimiter, it may cause query errors. However, the other delimiters (`field.delim`, `collection.delim`, `mapkey.delim`) are escaped, so they will not cause issues.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Oct 22, 2024
…text insert and fix reading null string bug (apache#42200) ## Proposed changes Add regression-test cases for hive text table properties: | **Property** | **Description** | **Example Value** | **Supported in Doris** | |------------------------------|---------------------------------------------------------------------|-------------------|----------------------| | `field.delim` | Defines the delimiter between columns in each row. | `\1` | Yes | | `collection.delim` | Defines the delimiter for items in an array (collection type). | `\2` | Yes | | `mapkey.delim` | Defines the delimiter between keys and values in a map. | `\3` | Yes | | `serialization.null.format` | Defines how `NULL` values are represented in the text file. | `\\N` | Yes | | `escape.delim` | Specifies the escape character used for escaping special characters.| `\\` | Yes | | `line.delim` | Defines the delimiter between rows or lines in the file. | `\n` | Yes | ### Explanation: - **`field.delim`**: This property is used to specify how columns are separated in a row. For example, `\1` indicates the delimiter is a non-printable character. - **`collection.delim`**: Used to define how elements in an array or collection are separated. In this case, `\2` is used as a separator. - **`mapkey.delim`**: This property defines how keys and values in a map are separated. For instance, `\3` is used to separate map keys and values. - **`serialization.null.format`**: This setting specifies the format for `NULL` values in the data. `\\N` is commonly used to represent `NULL`. - **`escape.delim`**: Defines the escape character used in the text file for escaping special characters, such as the delimiter itself. Here, `\\` is used as the escape character. - **`line.delim`**: This property is used to specify the delimiter between lines or rows. Typically, `\n` (newline) is used as the line delimiter. **Note**: Unlike the other delimiters, `line.delim` is not escaped. If the content in the table contains the same character as the line delimiter, it may cause query errors. However, the other delimiters (`field.delim`, `collection.delim`, `mapkey.delim`) are escaped, so they will not cause issues.
morningman
pushed a commit
that referenced
this pull request
Nov 1, 2024
## Proposed changes fellow #42200 Null values in text tables are now correctly recognized now.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Nov 1, 2024
## Proposed changes fellow apache#42200 Null values in text tables are now correctly recognized now.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Nov 1, 2024
## Proposed changes fellow apache#42200 Null values in text tables are now correctly recognized now.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
## Proposed changes fellow #42200 Null values in text tables are now correctly recognized now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add regression-test cases for hive text table properties:
field.delim\1collection.delim\2mapkey.delim\3serialization.null.formatNULLvalues are represented in the text file.\\Nescape.delim\\line.delim\nExplanation:
field.delim: This property is used to specify how columns are separated in a row. For example,\1indicates the delimiter is a non-printable character.collection.delim: Used to define how elements in an array or collection are separated. In this case,\2is used as a separator.mapkey.delim: This property defines how keys and values in a map are separated. For instance,\3is used to separate map keys and values.serialization.null.format: This setting specifies the format forNULLvalues in the data.\\Nis commonly used to representNULL.escape.delim: Defines the escape character used in the text file for escaping special characters, such as the delimiter itself. Here,\\is used as the escape character.line.delim: This property is used to specify the delimiter between lines or rows. Typically,\n(newline) is used as the line delimiter.Note: Unlike the other delimiters,
line.delimis not escaped. If the content in the table contains the same character as the line delimiter, it may cause query errors. However, the other delimiters (field.delim,collection.delim,mapkey.delim) are escaped, so they will not cause issues.